Hi #5
Merged
Hi #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… state Signed-off-by: Tanguy Pruvot <tanguy.pruvot@gmail.com>
|
I'm not really sure of the first commit... please check |
…not in these classes
…etween() and After() - recurrence object and data array members are now public
|
Hi... Just did a quick look through your changes and they look good. I'll do a more thorough check later today and then merge it.. |
|
Ok, i'm done for the moment :) there is a failed test FreqTest::testLastOccurrence, also with your version... but values remains the same I've added a demo JSCalendar of my forked version of Fullcalendar |
|
Great work! I'll merge it all in. When I finish the rework of my site, including the SG-iCal page I'll add you to the list of people who've contributed greatly. |
…currence or using lastOccurrence()
|
Great work! I merged all your changes in now. Updated the author-block on SG-iCal to reflect the extra authors. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are somes little fixes based on current issues... please merge them :)