Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use man page date instead of build date #542

Merged
merged 1 commit into from Mar 5, 2019

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Mar 5, 2019

Use man page date instead of build date
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.

Also use UTC to be independent of timezone.

note: This date call works with GNU date and BSD date (e.g. macOSX).

@iamleot
Copy link
Contributor

iamleot commented Mar 5, 2019 via email

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.
@bmwiedemann
Copy link
Contributor Author

GNU date and BSD date cover a lot of platforms. I know Solaris had a date without -r - is that a target for vimb? I now added a fallback there, so even on Solaris it will not be worse than before.

@iamleot
Copy link
Contributor

iamleot commented Mar 5, 2019 via email

@fanglingsu fanglingsu merged commit a884a81 into fanglingsu:master Mar 5, 2019
@fanglingsu
Copy link
Owner

@bmwiedemann Thank you for providing the patch. I've never thought about reproducible builds before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants