Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Use man page date instead of build date #542
Hello Bernhard, Bernhard M. Wiedemann writes:
Use man page date instead of build date in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good. Also use UTC to be independent of timezone.
While I think that's good to have, please note that `date -r' semantic is not portable (I think it is supported only by GNU date and maybe FreeBSD date(1)). I don't know if it will add possible more maintainance burden but maybe just bumping the date manually like vimb version for every stable release is another way to address possible non reproducible builds.
Bernhard M. Wiedemann writes:
GNU date and BSD date cover a lot of platforms. I know Solaris had a date without -r - is that a target for vimb? I now added a fallback there, so even on Solaris it will not be worse than before.
At least NetBSD and OpenBSD date(1) have a different semantic for `-r'. And, IMHO it would be better to address that unconditionally for every platform instead of having a different date depending on the platform.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.