New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added matlab object saving #10

Merged
merged 1 commit into from Sep 30, 2015

Conversation

Projects
None yet
2 participants
@sertansenturk
Contributor

sertansenturk commented Sep 25, 2015

Since many people incorporate MATLAB classes, it would be useful to support saving the (public) properties of matlab objects.

The code is tested for empty object, i.e. numel(obj) == 0; vector of objects. Currently, the code flattens 2D or higher dimensional array of objects to a vector.

fangq added a commit that referenced this pull request Sep 30, 2015

@fangq fangq merged commit 57d4523 into fangq:master Sep 30, 2015

@fangq

This comment has been minimized.

Show comment
Hide comment
@fangq

fangq Sep 30, 2015

Owner

thank you Sertan! people had requested this feature before.
your patch is in upstream now.

have you tested this with octave?

Owner

fangq commented Sep 30, 2015

thank you Sertan! people had requested this feature before.
your patch is in upstream now.

have you tested this with octave?

@sertansenturk

This comment has been minimized.

Show comment
Hide comment
@sertansenturk

sertansenturk Sep 30, 2015

Contributor

No problem, I'm happy that I am able to contribute :)

I have not tested it with Octave, sorry. This might not also work on earlier versions of MATLAB (< 2007-2008), where class syntax was different as far as I know.

Also, it might be good to add this capability to saveubjson.m too. I didn't want to change it before the initial pull request was revised.

Contributor

sertansenturk commented Sep 30, 2015

No problem, I'm happy that I am able to contribute :)

I have not tested it with Octave, sorry. This might not also work on earlier versions of MATLAB (< 2007-2008), where class syntax was different as far as I know.

Also, it might be good to add this capability to saveubjson.m too. I didn't want to change it before the initial pull request was revised.

@fangq

This comment has been minimized.

Show comment
Hide comment
@fangq

fangq Sep 30, 2015

Owner

I have not tested it with Octave, sorry. This might not also work on earlier versions of MATLAB (< 2007-2008), where class syntax was different as far as I know.

it would be nice to use the existing "isoct" variable or opt.IsOctave field in the savejson to test for octave.

Also, it might be good to add this capability to saveubjson.m too.

that would be nice too

Owner

fangq commented Sep 30, 2015

I have not tested it with Octave, sorry. This might not also work on earlier versions of MATLAB (< 2007-2008), where class syntax was different as far as I know.

it would be nice to use the existing "isoct" variable or opt.IsOctave field in the savejson to test for octave.

Also, it might be good to add this capability to saveubjson.m too.

that would be nice too

@sertansenturk

This comment has been minimized.

Show comment
Hide comment
@sertansenturk

sertansenturk Sep 30, 2015

Contributor

Ok, I'll make another pull request for saveubjson.m later this week. For octave, it might take a couple of more days...

Contributor

sertansenturk commented Sep 30, 2015

Ok, I'll make another pull request for saveubjson.m later this week. For octave, it might take a couple of more days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment