Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Dockerfile to accept a volume for the configuration directory. #2

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@kevinswiber
Copy link
Contributor

kevinswiber commented Mar 2, 2019

This remains backwards-compatible with older fanout/pushpin Docker images.

Example of how to take advantage of this:

docker run \
  -d \
  -p 7999:7999 \
  -p 5560-5563:5560-5563 \
  -v $(pwd)/examples/config:/etc/pushpin/ \
  --rm \
  --name pushpin \
  fanout/pushpin

The routes file in the example config directory routes to port 8000 on the Docker host.

Signed-off-by: Kevin Swiber kswiber@gmail.com

echo "* ${target},over_http" > /etc/pushpin/routes
fi

# If routes haven't been configured, use app:8080 for backwards-compatibility

This comment has been minimized.

@kevinswiber

kevinswiber Mar 5, 2019

Author Contributor

@jkarneges Do you want to maintain backward-compatibility with the default app:8080 backend? If we leave the default routesfile as * test, it might make for an easier Getting Started experience.

This comment has been minimized.

@jkarneges

jkarneges Mar 5, 2019

Member

I agree we should switch to * test.

This comment has been minimized.

@kevinswiber

kevinswiber Mar 5, 2019

Author Contributor

Done. Thanks.

@kevinswiber

This comment has been minimized.

Copy link
Contributor Author

kevinswiber commented Mar 5, 2019

@jkarneges Can we publish the django-eventstream chat example to Docker Hub so we can do a docker-compose example that spins up 3 containers (1 Pushpin, 2 Chat) and demonstrates a Pushpin deployment with a simple docker-compose up?

@kevinswiber kevinswiber force-pushed the kevinswiber:feature/configuration branch from 83d60c4 to a99e9a8 Mar 5, 2019

@kevinswiber

This comment has been minimized.

Copy link
Contributor Author

kevinswiber commented Mar 5, 2019

@jkarneges This is ready for review. We can integrate the docker-compose functionality in a future PR.

Updating the Docker image to accept a volume for the configuration di…
…rectory at container start time.

This remains backwards-compatible with older fanout/pushpin Docker images, with the exception of the default handler, which is now the Pushpin test handler instead of `app:8080`.

Deprecated Docker networking information has also been removed from the README.

Signed-off-by: Kevin Swiber <kswiber@gmail.com>

@kevinswiber kevinswiber force-pushed the kevinswiber:feature/configuration branch from 7a5b8c0 to faaa0b1 Mar 6, 2019

@jkarneges jkarneges merged commit 5524038 into fanout:master Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.