New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/comments #11

Closed
wants to merge 14 commits into
base: 8.x-1.x
from

Conversation

Projects
None yet
2 participants
@fantastic91
Owner

fantastic91 commented Jul 11, 2016

No description provided.

@@ -8,3 +8,4 @@ dependencies:
- inmail
- node
- user
- comment

This comment has been minimized.

@primsi

primsi Jul 13, 2016

Sold comment handler live in a separate sub module?

This comment has been minimized.

@fantastic91

fantastic91 Jul 15, 2016

Owner

Moved the code related to comments to mailhandler_d8_comment submodule.

// Create a comment entity.
$comment = Comment::create([
'entity_type' => 'node',

This comment has been minimized.

@primsi

primsi Jul 13, 2016

Should this leave in handler config, so we can support other entities to?

This comment has been minimized.

@fantastic91

fantastic91 Jul 15, 2016

Owner

Added configurable "entity_type" option on the handler.

$subject = str_replace(reset($matches), '', $subject);
// Validate whether user is allowed to post comments.
$user = $this->validateUser($result);

This comment has been minimized.

@primsi

primsi Jul 13, 2016

Should we validate if this bundle supports comments? And that even the entity exists?

This comment has been minimized.

This comment has been minimized.

@fantastic91

fantastic91 Jul 18, 2016

Owner

Seems like validate() doesn't "validate" entity ID, so I added custom validation for entity ID and bundle.

@fantastic91 fantastic91 deleted the features/comments branch Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment