Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

Separate the pulp_installer CI tests: release vs source #3

Merged
merged 3 commits into from Apr 22, 2020

Conversation

mikedep333
Copy link
Contributor

Required PR: pulp/pulp_installer#269

re: #6535

[noissue]

@vizipi
Copy link

vizipi bot commented Apr 21, 2020

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
33.33 % Fabricio Aguiar 2 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
README.md66.67 %2 out of 3 times

Committed file ranks

(click to expand)
  • 0.00%[.pulp_installer_tox.sh]
  • 66.67%[.github/workflows/pull_request.yaml]
  • 0.00%[.github/workflows/pulp_ci.yaml]
  • @vizipi vizipi bot requested a review from fao89 April 21, 2020 20:18
    @mikedep333 mikedep333 force-pushed the 6535_separate_tests branch 2 times, most recently from 13d3688 to 72feea1 Compare April 21, 2020 21:40
    Copy link
    Owner

    @fao89 fao89 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I really liked all the changes on .pulp_installer_tox.sh

    @@ -1,8 +1,18 @@
    #!/bin/bash
    # wrapper for inserting galaxy_ng_prerequisites into the pulp_installer CI
    set -x
    # COMMIT_MSG is only set if a PR
    export PULP_ROLES_PR_NUMBER=$(echo $COMMIT_MSG | grep -oP 'Required\ PR:\ https\:\/\/github\.com\/pulp\/pulp_installer\/pull\/(\d+)' | awk -F'/' '{print $7}')
    Copy link
    Owner

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice!

    @vizipi vizipi bot requested a review from fao89 April 22, 2020 15:54
    @fao89 fao89 merged commit b23efb9 into fao89:master Apr 22, 2020
    @mikedep333
    Copy link
    Contributor Author

    @fabricio-aguiar Actually, I reworded the final commit to Require a different pulp_installer PR, one that is only a draft and merged. I forgot to update the description.

    pulp/pulp_installer#272

    Ci is now broken on this repo because it's not merged yet.

    Of course, CI was broken on this repo anyway without this PR.

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants