Separate the pulp_installer CI tests: release vs source #3
Conversation
Required PR: pulp/pulp_installer#269 re: #6535 [noissue]
Required PR: pulp/pulp_installer#269 [noissue]
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks(click to expand)0.00%[.pulp_installer_tox.sh] 66.67%[.github/workflows/pull_request.yaml] 0.00%[.github/workflows/pulp_ci.yaml] |
13d3688
to
72feea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really liked all the changes on .pulp_installer_tox.sh
| @@ -1,8 +1,18 @@ | |||
| #!/bin/bash | |||
| # wrapper for inserting galaxy_ng_prerequisites into the pulp_installer CI | |||
| set -x | |||
| # COMMIT_MSG is only set if a PR | |||
| export PULP_ROLES_PR_NUMBER=$(echo $COMMIT_MSG | grep -oP 'Required\ PR:\ https\:\/\/github\.com\/pulp\/pulp_installer\/pull\/(\d+)' | awk -F'/' '{print $7}') | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Required PR: pulp/pulp_installer#272 re: #6547 [noissue]
72feea1
to
1a0cdb0
Compare
|
@fabricio-aguiar Actually, I reworded the final commit to Require a different pulp_installer PR, one that is only a draft and merged. I forgot to update the description. Ci is now broken on this repo because it's not merged yet. Of course, CI was broken on this repo anyway without this PR. |
Required PR: pulp/pulp_installer#269
re: #6535
[noissue]