Fix the conversion of list or tuple args to SQL. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is one element on the list, the generated SQL was (1,) (python notation of a single element tuple, which is not valid in SQL.
farcepest
added a commit
that referenced
this pull request
Nov 21, 2013
Fix the conversion of list or tuple args to SQL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a query with an argument which is a one element list (or tuple) for an IN clause, the generated SQL is not valid and the query fails.
Examples:
c.execute("SELECT * from T WHERE id IN %s", [[1, 2, 3]])-->SELECT * from T WHERE id IN ('1', '2', '3')OKc.execute("SELECT * from T WHERE id IN %s", [[1]])-->SELECT * from T WHERE id IN ('1',)Failc.execute("SELECT * from T WHERE id IN %(list)s", {'list': [1, 2, 3]})-->SELECT * from T WHERE id IN ('1', '2', '3')OKc.execute("SELECT * from T WHERE id IN %(list)s", {'list': [1]})-->SELECT * from T WHERE id IN ('1',)FailIn fact the list is converted as the string representation of a python tuple, with a final coma for one element tuples, and then breaks the SQL syntax.