Branches/python3 fixes #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2015 16:16
Build the argument vector ourselves to avoid invoking a subshell. Pass universal_newlines=True to the subprocess.check_output() call so that the return type of the output is str rather than bytes. Since the flag_map uses str keys, this was causing builds on Python 3 to fail to add the right compile and link flags, which caused symbol resolution failures at runtime due to the extension module not being linked against libnmsg.
This should add Python 3 compatibility while still supporting Python 2.7.
Closed
|
To be merged at a later date. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.