complete refactor

Author: bedrock-adam

config/outboxer.yml

@@ -1,6 +1,5 @@
 ---
 :batch_size: 1000
-:buffer_size: 10
 :concurrency: 1
 :tick_interval: 0.1
 :poll_interval: 5.0

lib/outboxer/message.rb

@@ -1,5 +1,5 @@
 module Outboxer
-  # Message lifecycle management including queuing, buffering, and publishing of messages.
+  # Message lifecycle management including queuing and publishing of messages.
   module Message
     module_function
 
@@ -61,7 +61,7 @@ def publish(logger: nil, time: ::Time)
         nil
       else
         logger&.info(
-          "Outboxer message publishing id=#{message[:id]}" \
+          "Outboxer message publishing id=#{message[:id]} " \
             "messageable_type=#{message[:messageable_type]} " \
             "messageable_id=#{message[:messageable_id]}")
 

lib/outboxer/publisher.rb

@@ -12,7 +12,7 @@ def terminating?
     # Parses command line arguments to configure the publisher.
     # @param args [Array<String>] The arguments passed via the command line.
     # @return [Hash] The parsed options including configuration path, environment,
-    # buffer size, batch_size, and intervals.
+    # batch_size, and intervals.
     def self.parse_cli_options(args)
       options = {}
 

lib/outboxer/web/views/message.erb

@@ -86,10 +86,9 @@
                             else
                                 0
                             end
-                    total_latency = queue_latency + buffer_latency + publish_latency
+                    total_latency = queue_latency + publish_latency
 
                     queue_percent = total_latency > 0 ? (queue_latency / total_latency * 100).round(2) : 0
-                    buffer_percent = total_latency > 0 ? (buffer_latency / total_latency * 100).round(2) : 0
                     publish_percent = total_latency > 0 ? (publish_latency / total_latency * 100).round(2) : 0
                 %>
                 <table class="table table-bordered">

lib/outboxer/web/views/publisher.erb

@@ -82,10 +82,6 @@
                         <th scope="row">Batch Size</th>
                         <td><%= publisher[:settings]['batch_size'] %></td>
                     </tr>
-                    <tr>
-                        <th scope="row">Buffer Size</th>
-                        <td><%= publisher[:settings]['buffer_size'] %></td>
-                    </tr>
                     <tr>
                         <th scope="row">Concurrency</th>
                         <td><%= publisher[:settings]['concurrency'] %></td>

spec/factories/outboxer_publishers.rb

@@ -4,7 +4,6 @@
     status { Outboxer::Publisher::Status::PUBLISHING }
     settings do
       {
-        "buffer_size" => 1000,
         "concurrency" => 3,
         "tick_interval" => 0.1,
         "poll_interval" => 5.0,

spec/lib/outboxer/publisher/all_spec.rb

@@ -9,7 +9,6 @@ module Outboxer
             name: "server-09:67000",
             status: Publisher::Status::PUBLISHING,
             settings: {
-              "buffer_size" => 1000,
               "concurrency" => 2,
               "tick_interval" => 0.1,
               "poll_interval" => 5.0,
@@ -46,7 +45,6 @@ module Outboxer
           expect(publishers[0][:name]).to eq(publisher.name)
           expect(publishers[0][:status]).to eq("publishing")
           expect(publishers[0][:settings]).to eq({
-            "buffer_size" => 1000,
             "concurrency" => 2,
             "tick_interval" => 0.1,
             "poll_interval" => 5.0,

spec/lib/outboxer/publisher/find_by_id_spec.rb

@@ -9,7 +9,6 @@ module Outboxer
             name: "server-09:67000",
             status: Publisher::Status::PUBLISHING,
             settings: {
-              "buffer_size" => 1000,
               "concurrency" => 2,
               "tick_interval" => 0.1,
               "poll_interval" => 5.0,
@@ -45,7 +44,6 @@ module Outboxer
           expect(result[:name]).to eq(publisher.name)
           expect(result[:status]).to eq("publishing")
           expect(result[:settings]).to eq({
-            "buffer_size" => 1000,
             "concurrency" => 2,
             "tick_interval" => 0.1,
             "poll_interval" => 5.0,