Add maybe copy tests #980
Merged
Add maybe copy tests #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jph00
requested changes
Oct 27, 2018
tests/test_core.py
Outdated
| assert (df['col3'].dtypes == 'int64') | ||
|
|
||
| def _write_file(name): |
There was a problem hiding this comment.
I tried this initially but was getting errors. Googled for this and seems you can skip one line feed, but not two.
The clean_up function is going away thx to TemporaryDirectory - let me see what I can do about the _write_file one.
There was a problem hiding this comment.
this looks nicer :)
def _write_file(dn, name): f = open(f'{dn}/{name}', 'w'); f.write(str(name)); f.close()
tests/test_core.py
Outdated
|
|
||
| def test_copies_if_older(self): | ||
| _write_file('first') |
There was a problem hiding this comment.
Probably best to use the tempfile std lib and a with block to ensure that the files are created somewhere appropriate, and automatically cleaned up when done.
|
Rebased on master and started to squash commits out of habit - hoping changing history did not mess anything up with the workflow on github. |
|
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get my feet wet with pytest, picked something relatively straight forward from
fastai.core. Fixed a couple of typos along the way and made minor change tomaybe_copy.Will start a thread to discuss.