Skip to content
This repository has been archived by the owner on Nov 13, 2022. It is now read-only.

fix for Twitter card preview of main blog page #361

Merged
merged 1 commit into from Jul 22, 2020

Conversation

drscotthawley
Copy link
Contributor

@drscotthawley drscotthawley commented Jul 20, 2020

Two simple one-line changes to enable Twitter card/preview of main blog page.
As per Forums thread: https://forums.fast.ai/t/fastpages-no-twitter-card-for-main-page/75209

Demo URL: https://drscotthawley.github.io/devblog4/. Try entering that URL into Twitter Card Validator vs. entering https://fastpages.fast.ai/

@drscotthawley
Copy link
Contributor Author

drscotthawley commented Jul 20, 2020

Might be that _includes/custom_head.html would be a preferable (i.e. more in keeping with minima theme) place to put the twitter meta tag instead of _includes/head.html.
If so, I'd be happy to make that switch.

@hamelsmu
Copy link
Member

/preview

@github-actions github-actions bot added the draft build pending Indicates that a preview of your site is being built from your PR label Jul 22, 2020
@github-actions
Copy link

A preview build of this branch has been generated for SHA: c0386d0 and can be viewed live at: https://5f178dc70718be0d2cbceb76--fastpages.netlify.app

The current fastpages site built from master can be viewed for comparison here

@github-actions github-actions bot removed the draft build pending Indicates that a preview of your site is being built from your PR label Jul 22, 2020
@hamelsmu
Copy link
Member

Thanks!

@hamelsmu hamelsmu merged commit 31e8899 into fastai:master Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants