Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generated project cache in CI workflow #107

Closed
1 task done
rszamszur opened this issue Jun 10, 2022 · 0 comments · Fixed by #142
Closed
1 task done

Improve generated project cache in CI workflow #107

rszamszur opened this issue Jun 10, 2022 · 0 comments · Fixed by #142
Labels
automation Related to project CI/CD

Comments

@rszamszur
Copy link
Member

rszamszur commented Jun 10, 2022

  • I have searched the issues of this repo and believe that this is not a duplicate.

Feature Request

I think the cache key for the generated project should be improved. There are cases where I'd expect the generated project to be regenerated instead of being taken from the cache. For instance:
https://github.com/rszamszur/fastapi-mvc/actions/runs/2471988430

Cookiecutter dependency was updated but the generated project was taken from a cache. Since the cookie-cutter is responsible for generating, it shouldn't be taken from a cache.

There could be more edge cases like this with the current cache key.

@rszamszur rszamszur added the automation Related to project CI/CD label Jun 10, 2022
@rszamszur rszamszur changed the title Improve generated project cache in CI Improve generated project cache in CI workflow Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Related to project CI/CD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant