Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controller generator creating duplicates entries in config/router.py #92

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

rszamszur
Copy link
Member

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #78

Description of the changes being introduced by the pull request:

@rszamszur rszamszur added the bug Something isn't working label Apr 26, 2022
@rszamszur rszamszur added this to the 0.11.1 milestone Apr 26, 2022
@rszamszur rszamszur self-assigned this Apr 26, 2022
@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #92 (f8850e8) into master (ea22c7a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files          39       39              
  Lines         808      797      -11     
==========================================
- Hits          805      794      -11     
  Misses          3        3              
Impacted Files Coverage Δ
...r_name}}/{{cookiecutter.package_name}}/app/asgi.py 100.00% <ø> (ø)
...ter.package_name}}/app/controllers/api/v1/ready.py 100.00% <ø> (ø)
.../{{cookiecutter.package_name}}/app/models/ready.py 100.00% <ø> (ø)
...cookiecutter.package_name}}/app/models/response.py 100.00% <ø> (ø)
...ecutter.package_name}}/app/utils/aiohttp_client.py 100.00% <ø> (ø)
...}/{{cookiecutter.package_name}}/app/utils/redis.py 100.00% <ø> (ø)
...{cookiecutter.package_name}}/cli/commands/serve.py 100.00% <ø> (ø)
...}/{{cookiecutter.package_name}}/config/__init__.py 100.00% <ø> (ø)
...{cookiecutter.package_name}}/config/application.py 100.00% <ø> (ø)
...me}}/{{cookiecutter.package_name}}/config/redis.py 100.00% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688308f...f8850e8. Read the comment docs.

@rszamszur rszamszur merged commit 0d80713 into master Apr 27, 2022
@rszamszur rszamszur deleted the fix/#78 branch April 27, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller generator is creating duplicates entries in config/router.py
2 participants