-
-
Notifications
You must be signed in to change notification settings - Fork 80
📝 Add sniffio dependency to project requirements
#421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 Docs previewLast commit 1876898 at: https://1e7c617c.asyncer.pages.dev |
|
I just ran into this too, it'd also be good to set up some lint tooling to confirm all referenced dependencies are added as explicit first order dependencies. Maybe too much scope creep but adding https://github.com/fpgmaas/deptry as a pre-commit lint to check it flags this as a problem then fix it would be good for preventing this sort of issue reoccurring. |
|
@svlandeg Sorry to tag you but you guys' package is broken. Could you please check it? |
tiangolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙌
This will be available in Asyncer 0.0.11 released in the next hours. 🚀
|
Thanks, @tiangolo and @jujumilk3 and team for the fast work on this. 🚀 I have had very good experiences with |
asyncer now declares sniffio as a dependency (fastapi/asyncer#421), so we no longer need to pin it directly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
## Summary - Remove direct `sniffio>=1.3.1` dependency from vibetuner-py - asyncer now declares sniffio as a dependency (fastapi/asyncer#421 merged Dec 1, 2025) - sniffio remains available transitively through asyncer ## Test plan - [x] `uv sync` completes successfully - [x] Lock files updated correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
It fails to import with
anyio>=4.12.0due to missingsniffiodependency.(https://anyio.readthedocs.io/en/stable/versionhistory.html)
The most critical issue is that many projects depending on asyncer (without pinning anyio<4.12 or sniffio) are broken. You can easily verify this by
pip install asyncerandimport asyncer.