New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object and null possible type handling. #104

Merged
merged 2 commits into from Jul 5, 2018

Conversation

Projects
None yet
3 participants
@ruiaraujo
Contributor

ruiaraujo commented Jul 4, 2018

Remove ajv for multiple type handling.

The removal of ajv was not related with this fix but its need is showcased by the edited benchmark.

Before:

JSON.stringify obj x 1,624,624 ops/sec ±0.72% (91 runs sampled)
fast-json-stringify obj x 729,975 ops/sec ±0.96% (92 runs sampled)
fast-json-stringify-uglified obj x 730,695 ops/sec ±0.73% (93 runs sampled)

After:

JSON.stringify obj x 1,638,558 ops/sec ±1.08% (91 runs sampled)
fast-json-stringify obj x 6,023,692 ops/sec ±0.82% (92 runs sampled)
fast-json-stringify-uglified obj x 5,895,250 ops/sec ±0.91% (93 runs sampled)
@mcollina

LGTM

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Jul 5, 2018

Member

Good spot!

Member

mcollina commented Jul 5, 2018

Good spot!

@delvedor

LGTM

@mcollina mcollina merged commit 4aaaff6 into fastify:master Jul 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment