Incompatible with fastify 1.0-rc.1

[yamalight]

fastify-auth is currently incompatible with 1.0-rc.1, throws the following error:

    fastify-plugin - expected '>=0.13.1' fastify version, '1.0.0-rc.1' is installed

      1 | // npm packages
      2 | const initFastify = require('fastify');
    > 3 | const fastifyAuth = require('fastify-auth');

Updating fastify-plugin should probably fix this, right? Should I send a PR?

[mcollina]

Unfortunately that commit didn't really fix it. I'll need to get some more work done.

[yamalight]

@mcollina does this comment covers all that needs to be done? If that's the case - I can prepare a PR in a few mins

[mcollina]

there is a little bit more work involved, as tests are not currently passing. Il giorno lun 12 feb 2018 alle 09:41 Tim Ermilov <notifications@github.com> ha scritto:

…

@mcollina <https://github.com/mcollina> does this comment <fastify/fastify#229 (comment)> covers all that needs to be done? If that's the case - I can prepare a PR in a few mins — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL47mEUWqZi7hHa7bgPubO9-Ajw8pJks5tUE2UgaJpZM4SCHh-> .

[jsumners]

The tests are written against an outdated pattern. They are attempting to register routes after the Fastify server is already listening. The tests themselves should be fine, there just needs to be a bit of refactoring done to build the test server correctly, e.g. fastify/fastify-url-data@65b158b.

[mcollina]

the tests depends on fastify-leveldb being updated as well. I've already done the work, I just need publish rights (but @delvedor is skying somewhere in the mountains).

[mcollina]

Solved in 0.2.0.