Skip to content

chore: lint code and update deps to pass tests #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 4 commits into from
Mar 15, 2021
Merged

chore: lint code and update deps to pass tests #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92b097b
chore(index): lint with standard
Mar 15, 2021
d5bda7b
docs(readme): add npm and snyk badges
Mar 15, 2021
5eb98cd
build(deps-dev): add @types/node
Mar 15, 2021
5c714e0
build(deps-dev): bump tsd from 0.11.0 to 0.14.0
Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# fastify-basic-auth

[![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg?style=flat)](http://standardjs.com/) ![CI](https://github.com/fastify/fastify-basic-auth/workflows/CI/badge.svg)
![CI](https://github.com/fastify/fastify-basic-auth/workflows/CI/badge.svg?branch=master)
[![NPM version](https://img.shields.io/npm/v/fastify-basic-auth.svg?style=flat)](https://www.npmjs.com/package/fastify-basic-auth)
[![Known Vulnerabilities](https://snyk.io/test/github/fastify/fastify-basic-auth/badge.svg)](https://snyk.io/test/github/fastify/fastify-basic-auth)
[![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg?style=flat)](https://standardjs.com/)

A simple basic auth plugin for Fastify.

Expand Down
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ function basicPlugin (fastify, opts, next) {
if (authenticateHeader) {
reply.header(authenticateHeader.key, authenticateHeader.value)
}
var credentials = auth(req)
const credentials = auth(req)
if (credentials == null) {
done(new Unauthorized('Missing or bad formatted authorization header'))
} else {
var result = validate(credentials.name, credentials.pass, req, reply, done)
const result = validate(credentials.name, credentials.pass, req, reply, done)
if (result && typeof result.then === 'function') {
result.then(done, done)
}
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,12 @@
},
"homepage": "https://github.com/fastify/fastify-basic-auth#readme",
"devDependencies": {
"@types/node": "^14.14.34",
"fastify": "^3.0.0",
"fastify-auth": "^1.0.0",
"standard": "^16.0.1",
"tap": "^14.10.7",
"tsd": "^0.11.0"
"tsd": "^0.14.0"
},
"dependencies": {
"basic-auth": "^2.0.1",
Expand Down