Skip to content

Conversation

@climba03003
Copy link
Member

@climba03003 climba03003 commented Apr 8, 2021

Changes:

  1. fix unhandled error throw by plugin
  2. increase test coverage to 100%
  3. prepare for tap 15

Checklist

}

throw Error('Basic Auth: Invalid authenticate option')
next(new Error('Basic Auth: Invalid authenticate option'))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing error here will lead to avvio timeout as the throwing error is not properly consumed by avvio.
We need to pass the Error to the callback if we are using callback-style here.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c971b79 into fastify:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants