feat: add header option (#47) #52
Conversation
|
Could you please add a test for this as well https://github.com/fastify/fastify-basic-auth/blob/master/index.test-d.ts? |
mattyod
force-pushed
the
add-header-option-47
branch
from
1d11227 to
52f9434
Compare
|
Added an optional header to one of the existing tests, does that cover us? |
| ```js | ||
| fastify.register(require('fastify-basic-auth'), { | ||
| validate, | ||
| header: 'x-forwarded-authorization' |
There was a problem hiding this comment.
could we mention that it must be lowercase or add a lowercase function?
There was a problem hiding this comment.
Otherwise the lookup of the header will fail.
There was a problem hiding this comment.
I've added the .toLowerCase() suggestion from @mcollina. Will update the test to reflect this.
There was a problem hiding this comment.
Updated the test to demonstrate the to lowercasing. Not sure it needs a whole test of it's own but let me know if that's not enough.
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
This would also need an added test
mattyod
force-pushed
the
add-header-option-47
branch
from
0ab3580 to
0b4f90c
Compare
Allow for a 'header' property to be specified in the options object.
If present use the value specified as the name of the header from
which to extract credentials for validation.
mattyod
force-pushed
the
add-header-option-47
branch
from
0b4f90c to
4303901
Compare
4 participants
Checklist
npm run testandnpm run benchmarkand the Code of conduct