From dc55e0c091b39abfa8a589df7bcd0e620fbe13b9 Mon Sep 17 00:00:00 2001 From: "greenkeeper[bot]" <23040076+greenkeeper[bot]@users.noreply.github.com> Date: Mon, 19 Aug 2019 21:31:47 +0000 Subject: [PATCH 1/2] chore(package): update standard to version 14.0.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 071188d9..d7cf89ee 100644 --- a/package.json +++ b/package.json @@ -67,7 +67,7 @@ "rimraf": "^3.0.0", "simple-get": "^3.0.3", "sinon": "^7.3.2", - "standard": "^13.0.1", + "standard": "^14.0.0", "tap": "^12.5.3", "walker": "^1.0.7" }, From 65b62587af8d91f92cd3a3c115103e244555935d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Denis=20F=C3=A4cke?= Date: Wed, 21 Aug 2019 19:29:44 +0200 Subject: [PATCH 2/2] fix linting errors for standard@14 --- generate-readme.js | 4 ++-- generate.js | 6 +++--- test/generate.test.js | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/generate-readme.js b/generate-readme.js index 3edf6b5f..df60e25a 100644 --- a/generate-readme.js +++ b/generate-readme.js @@ -35,9 +35,9 @@ function generate (dir, { pluginMeta, encapsulated, pluginFileName }, cb) { let accessibilityTemplate = '' if (!encapsulated) { - accessibilityTemplate = `- [X] Accessible in the same context where you require them\n- [ ] Accessible only in a child context\n` + accessibilityTemplate = '- [X] Accessible in the same context where you require them\n- [ ] Accessible only in a child context\n' } else { - accessibilityTemplate = `- [ ] Accessible in the same context where you require them\n- [X] Accessible only in a child context\n` + accessibilityTemplate = '- [ ] Accessible in the same context where you require them\n- [X] Accessible only in a child context\n' } const fastifyDecorators = toMarkdownList(pluginMeta.decorators.fastify) diff --git a/generate.js b/generate.js index 3d85af44..0c666de8 100755 --- a/generate.js +++ b/generate.js @@ -53,16 +53,16 @@ function generate (dir, cb) { }) pkg.devDependencies = Object.assign(pkg.devDependencies || {}, { - tap: cliPkg.devDependencies['tap'] + tap: cliPkg.devDependencies.tap }) - log('debug', `edited package.json, saving`) + log('debug', 'edited package.json, saving') writeFile('package.json', JSON.stringify(pkg, null, 2), (err) => { if (err) { return cb(err) } - log('debug', `saved package.json`) + log('debug', 'saved package.json') log('info', `project ${pkg.name} generated successfully`) log('debug', `run '${chalk.bold('npm install')}' to install the dependencies`) log('debug', `run '${chalk.bold('npm start')}' to start the application`) diff --git a/test/generate.test.js b/test/generate.test.js index d096ff76..85445793 100644 --- a/test/generate.test.js +++ b/test/generate.test.js @@ -127,10 +127,10 @@ function define (t) { t.equal(pkg.scripts.start, 'fastify start -l info app.js') t.equal(pkg.scripts.dev, 'fastify start -l info -P app.js') t.equal(pkg.dependencies['fastify-cli'], '^' + cliPkg.version) - t.equal(pkg.dependencies['fastify'], cliPkg.dependencies.fastify) + t.equal(pkg.dependencies.fastify, cliPkg.dependencies.fastify) t.equal(pkg.dependencies['fastify-plugin'], cliPkg.devDependencies['fastify-plugin'] || cliPkg.dependencies['fastify-plugin']) t.equal(pkg.dependencies['fastify-autoload'], cliPkg.devDependencies['fastify-autoload']) - t.equal(pkg.devDependencies['tap'], cliPkg.devDependencies['tap']) + t.equal(pkg.devDependencies.tap, cliPkg.devDependencies.tap) const testGlob = pkg.scripts.test.split(' ')[1] t.equal(minimatch.match(['test/services/plugins/more/test/here/ok.test.js'], testGlob).length, 1)