Skip to content

Conversation

@delvedor
Copy link
Member

@delvedor delvedor commented May 6, 2017

This pr is to prepare the direct integration of the cli with Fastify, once we approve this I'll update Fastify by adding the following code to the package.json:

  "bin": {
    "fastify": "./node_modules/.bin/fastify"
  },

In this way the users can use the cli out of the box.

What is inside this pr:

delvedor added 2 commits May 7, 2017 01:00
- Added pretty logs with pino-colada
- Added address option
- Added update notifier for fastify
@delvedor delvedor requested a review from mcollina May 6, 2017 23:09
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I do not think your bin section will work when installed both when installed with -g and with --save. npm layout is not-deterministic, so you'll need to do require('fastify-cli')() or something similar.

@delvedor
Copy link
Member Author

delvedor commented May 7, 2017

Yeah, you are right.
If we install fastify-cli as dependency in Fastify and we add it in bin will work only if the user runs it via npm.

npm layout is not-deterministic, so you'll need to do require('fastify-cli')() or something similar.

I didn't understand this.

@delvedor delvedor merged commit 326de1c into master May 21, 2017
@delvedor delvedor deleted the prettyLogs-updateNotify branch May 21, 2017 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants