chore: make sha1 the default algo - #98
Merged
Merged
Conversation
mcollina
requested changes
Feb 10, 2023
Contributor
Author
|
Updated according to your review and added recommendations based on our convo in #91 |
Contributor
Author
|
had to fix a linter warning, sorry (my git removed a newline from fnv1a.js) |
climba03003
approved these changes
Feb 10, 2023
Contributor
|
We could add a validation for the algorithm. So that we can throw on plugin registration and not on the first request. |
Contributor
|
LOL we have that already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct