feat(types): support define custom payload #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uinz
changed the title
Ethan-Arrowood
suggested changes
Nov 25, 2020
| }); | ||
|
|
||
| // define custom payload |
There was a problem hiding this comment.
could you create a new testing file that has some declaration merging and tests for it?
There was a problem hiding this comment.
Declaring the module will pollute the global type environment, I have not found a good way to use dts to test
There was a problem hiding this comment.
Do we really care about adding types to the global type env? I think we should test this properly.
There was a problem hiding this comment.
Good point, this is good to go then
|
Well done. I like this PR! |
Ethan-Arrowood
approved these changes
Dec 14, 2020
| }); | ||
|
|
||
| // define custom payload |
There was a problem hiding this comment.
Good point, this is good to go then
fox1t
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct