Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): explicitly declare js module type #332

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 27, 2023

Node 21.1.0 added a flag to detect module types, which will probably become default in the future. Declaring the type will cause Node to skip detection on startup, reducing startup time.

Declaring the package type is also considered good practice according to https://nodejs.org/api/modules.html#enabling anyway, and the main fastify repo already does it.

Will update the rest of the repos and point to this PR in their PRs.

Checklist

@gurgunday gurgunday merged commit 3b94207 into master Oct 27, 2023
9 checks passed
@gurgunday gurgunday deleted the Fdawgs-patch-1 branch October 27, 2023 08:23
This was referenced Oct 27, 2023
This was referenced Oct 27, 2023
@simoneb
Copy link

simoneb commented Oct 27, 2023

To be honest I don't think this will ever happen, as it would break existing applications. I would find it more likely that from a major version onwards, it will default it to module instead of cjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants