New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable specifying interface for context data #48
Conversation
Thank you! Could you please add tsd test for this change? |
Not sure how my changes could break that test? It passes on my machine with node 16 and I did not change any of the actual code... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, seems a flaky test
Will review the test and merge later today. |
@awlayton Could you also please add simple example of this new feature into README.md? |
And with regards to tests failing - it actually seems to be related to ALS changes in 16.2.0. I've fixed tests to handle errors properly, and will now investigate the actual underlying cause. |
Thank you! |
Published in 2.2.0 |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct
This allows specifying types for the data stored in the request context which are then respected by
get
andset
.npm run test:typescript
still passes.