Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for checking multipart request using form-data module #1026

Merged
merged 2 commits into from Jul 8, 2018

Conversation

Projects
None yet
3 participants
@allevo
Copy link
Member

commented Jul 6, 2018

The injection using form-data module doesn't work properly.

A test is added.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@allevo allevo added the enhancement label Jul 6, 2018

@allevo allevo requested review from mcollina and delvedor Jul 6, 2018

@mcollina

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

Ouch! Would you be able to send a fix to https://github.com/fastify/light-my-request?

@allevo

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2018

Yeah. I'd like to keep this test here too. Is it oki?

@mcollina

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

definitely.

@mcollina

This comment has been minimized.

Copy link
Member

commented Jul 7, 2018

I think this can land now. Can you also update the minimum version of light-my-request to 2.0.3 in package.json?

@allevo

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2018

Done

@delvedor
Copy link
Member

left a comment

LGTM once CI is green

@allevo

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2018

CI restarted. Now it is green.

@allevo allevo merged commit 7f734fd into master Jul 8, 2018

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.8%) to 97.473%
Details

@allevo allevo deleted the add-form-data-test-for-multipart-request branch Jul 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.