Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct typos in Github Issue Template #1140

Merged
merged 1 commit into from Sep 5, 2018
Merged

Correct typos in Github Issue Template #1140

merged 1 commit into from Sep 5, 2018

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 5, 2018

Checklist

  • run npm run test and npm run benchmark
  • commit message and code follows Code of conduct

StarpTech
StarpTech approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 0a27c92 into fastify:master Sep 5, 2018
@trivikr trivikr deleted the github-template branch September 5, 2018 14:20
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@StarpTech StarpTech StarpTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trivikr @mcollina @StarpTech