Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against prototype poisoning #1427

Merged
merged 2 commits into from Feb 2, 2019
Merged

Protect against prototype poisoning #1427

merged 2 commits into from Feb 2, 2019

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Feb 2, 2019

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@delvedor delvedor added feature backport 1.x Issue or pr that should be backported to Fastify v1 labels Feb 2, 2019
delvedor
delvedor approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsumners
jsumners approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 720fb25 into master Feb 2, 2019
@cemremengu cemremengu deleted the fix-1426 branch February 3, 2019 05:55
@delvedor delvedor mentioned this pull request Feb 3, 2019
Closed
@hueniverse
Copy link

Nice.

delvedor pushed a commit that referenced this pull request Feb 4, 2019
@mcollina @delvedor
Protect against prototype poisoning (#1427)
a749889 
* Protect against prototype poisoning

* Renamed protoAction to onProtoPoisoning
This was referenced Feb 10, 2019
Open
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
@Eomm Eomm added the semver-minor Issue or PR that should land as semver minor label Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
backport 1.x Issue or pr that should be backported to Fastify v1 semver-minor Issue or PR that should land as semver minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mcollina @hueniverse @jsumners @delvedor @Eomm