New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes image layout with long metatdata #17

Merged
merged 2 commits into from Nov 12, 2014

Conversation

Projects
None yet
2 participants
@foozmeat
Contributor

foozmeat commented Nov 12, 2014

No description provided.

foozmeat added some commits Nov 12, 2014

Fixes image layout when app metadata is really long
Previously images would get written off the bottom of the page. This change makes sure that new pages are inserted if needed.
@foozmeat

This comment has been minimized.

Show comment
Hide comment
@foozmeat

foozmeat Nov 12, 2014

Member

I added that line myself while fixing the bug.

Member

foozmeat commented on dd04f9b Nov 12, 2014

I added that line myself while fixing the bug.

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Nov 12, 2014

Yes, I just saw it, looked at the commits in the wrong order, sorry.

KrauseFx replied Nov 12, 2014

Yes, I just saw it, looked at the commits in the wrong order, sorry.

KrauseFx added a commit that referenced this pull request Nov 12, 2014

Merge pull request #17 from panicinc/master
fixes image layout with long metatdata

@KrauseFx KrauseFx merged commit 5581685 into fastlane-old:master Nov 12, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Nov 12, 2014

Collaborator

That looks great! Thanks for the Pull Request 👍

Collaborator

KrauseFx commented Nov 12, 2014

That looks great! Thanks for the Pull Request 👍

@fastlane-old fastlane-old locked and limited conversation to collaborators Mar 11, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.