Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Adds ability to select team. #7

Merged
merged 1 commit into from Nov 27, 2014

Conversation

esttorhe
Copy link
Contributor

@esttorhe esttorhe commented Nov 27, 2014

Closes #4

@KrauseFx Please check if this matches your code standards (if not feel free to change anything or throw it out the window as you prefer 馃槈
Also maybe this could benefit from receiving the team as an option(?).

Right now I'm showing the list of teams so its easier for the user to select which one they want to manipulate.
See example below:
screen_shot_2014-11-26_at_23_13_15

Edit: Forgot to mention; I modified the README although did not add a shoutout, don't know if you are used to that

@KrauseFx
Copy link
Collaborator

KrauseFx commented Nov 27, 2014

This looks really good, thanks @esttorhe. I'll take a closer look today.

@muffe
Copy link

muffe commented Nov 27, 2014

Works like a charm :) 馃憤

@KrauseFx
Copy link
Collaborator

KrauseFx commented Nov 27, 2014

I just checked: This breaks the login for users who are in only one team.

begin
all(".button.large.blue.signin-button").first.click
(wait_for_elements('#saveTeamSelection') rescue nil) # If the user is not on multiple teams
Copy link
Collaborator

@KrauseFx KrauseFx Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're looking for multiple teams in any case.
Please include a check like page.has_content?"Select your Team" or something which only is displayed when being asked for the team.

Copy link
Contributor Author

@esttorhe esttorhe Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槉 Oops. Sorry about that.聽Apple has two different team selection pages ; one with a select and the other with radio buttons.聽

Spent some time trying with the select one because I didn't check that when accessing the profiles directly Apple shows the radio button and removed the has_content? as a desperate attempt and forgot to change it.聽馃槖

Will change it and test that the teams part still works; sadly I can't test the single team flow since my account is associated with multiple teams.

On Thu, Nov 27, 2014 at 4:45 AM, Felix Krause notifications@github.com
wrote:

     begin
  •      all(".button.large.blue.signin-button").first.click
    
  •      (wait_for_elements('#saveTeamSelection') rescue nil) # If the user is not on multiple teams
    

    It looks like you're looking for multiple teams in any case.
    Please include a check like page.has_content?"Select your Team" or something which only is displayed when being asked for the team.

    Reply to this email directly or view it on GitHub:
    https://github.com/KrauseFx/sigh/pull/7/files#r20989108

@KrauseFx
Copy link
Collaborator

KrauseFx commented Nov 27, 2014

It looks good. @muffe Can you confirm the new version works for you as well?

@muffe
Copy link

muffe commented Nov 27, 2014

The multi user part is working fine. Can't say anything about the single team users though.

@KrauseFx
Copy link
Collaborator

KrauseFx commented Nov 27, 2014

Just tested it, looks great! Thanks @esttorhe and @muffe
Merging 馃憤

KrauseFx added a commit that referenced this pull request Nov 27, 2014
@KrauseFx KrauseFx merged commit a3687d1 into fastlane-old:master Nov 27, 2014
@KrauseFx
Copy link
Collaborator

KrauseFx commented Nov 27, 2014

@esttorhe @muffe Could you test my update: 0fd394c

The following needs to be tested:

  • It works as before (I renamed and refactored some things)
  • You can pass the name of your preferred team (the ID) using the environment variable SIGH_TEAM_ID

@esttorhe
Copy link
Contributor Author

esttorhe commented Nov 27, 2014

@KrauseFx 馃憣

@esttorhe esttorhe deleted the supportMultipleTeams branch Nov 27, 2014
@KrauseFx
Copy link
Collaborator

KrauseFx commented Nov 27, 2014

Perfect, I'll release a new version then 馃憤

@KrauseFx
Copy link
Collaborator

KrauseFx commented Nov 27, 2014

New version is live, thanks for your help.

@esttorhe
Copy link
Contributor Author

esttorhe commented Nov 27, 2014

Sweet. Glad it worked 馃帀

On Thu, Nov 27, 2014 at 5:58 PM, Felix Krause notifications@github.com
wrote:

New version is live, thanks for your help.

Reply to this email directly or view it on GitHub:
#7 (comment)

@fastlane-old fastlane-old locked and limited conversation to collaborators Mar 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to handle when a user is on multiple teams
3 participants