-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This looks really good, thanks @esttorhe. I'll take a closer look today. |
Works like a charm :) 👍 |
I just checked: This breaks the login for users who are in only one team. |
begin | ||
all(".button.large.blue.signin-button").first.click | ||
(wait_for_elements('#saveTeamSelection') rescue nil) # If the user is not on multiple teams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you're looking for multiple teams in any case.
Please include a check like page.has_content?"Select your Team"
or something which only is displayed when being asked for the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😊 Oops. Sorry about that. Apple has two different team selection pages ; one with a select and the other with radio buttons.
Spent some time trying with the select one because I didn't check that when accessing the profiles directly Apple shows the radio button and removed the has_content?
as a desperate attempt and forgot to change it. :unamused:
Will change it and test that the teams part still works; sadly I can't test the single team
flow since my account is associated with multiple teams.
On Thu, Nov 27, 2014 at 4:45 AM, Felix Krause notifications@github.com
wrote:
begin
all(".button.large.blue.signin-button").first.click
(wait_for_elements('#saveTeamSelection') rescue nil) # If the user is not on multiple teams
It looks like you're looking for multiple teams in any case.
Reply to this email directly or view it on GitHub:
Please include a check likepage.has_content?"Select your Team"
or something which only is displayed when being asked for the team.
https://github.com/KrauseFx/sigh/pull/7/files#r20989108
It looks good. @muffe Can you confirm the new version works for you as well? |
The multi user part is working fine. Can't say anything about the single team users though. |
1534cf3
to
a54ffda
Compare
Perfect, I'll release a new version then 👍 |
New version is live, thanks for your help. |
Sweet. Glad it worked 🎉 On Thu, Nov 27, 2014 at 5:58 PM, Felix Krause notifications@github.com
|
Closes #4
@KrauseFx Please check if this matches your code standards (if not feel free to change anything or throw it out the window as you prefer 😉
Also maybe this could benefit from receiving the team as an option(?).
Right now I'm showing the list of teams so its easier for the user to select which one they want to manipulate.

See example below:
Edit: Forgot to mention; I modified the README although did not add a shoutout, don't know if you are used to that