Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow auto populate email field #226

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@josephbona
Copy link
Contributor

josephbona commented Jul 30, 2018

Allows the form's email field to be set with URL param

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jul 30, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no label Jul 30, 2018

@josephbona

This comment has been minimized.

Copy link
Contributor Author

josephbona commented Jul 31, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jul 31, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jul 31, 2018

@KrauseFx

This comment has been minimized.

Copy link
Member

KrauseFx commented Aug 6, 2018

Hey @josephbona, thanks for your PR, the code looks good. Can you tell us a bit more about the use-case though, and add a line of comment into the code base on what it's used for?

@josephbona

This comment has been minimized.

Copy link
Contributor Author

josephbona commented Aug 8, 2018

@KrauseFx For Barstool we had a screener form to sign up for our test flight beta onebite.app. We collected their email address there then redirected to the fastlane page and passed the email address as a url param.

I could also see this being used if you are sending out a testflight invite to an email list.

@taquitos
Copy link
Member

taquitos left a comment

Tested and seems reasonable 👍

@taquitos taquitos merged commit bb07a09 into fastlane:master Mar 8, 2019

1 check passed

cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.