added the variable in the heroku deployment env (app.json) and update…

[coderbec]

…d the readme with a link to the docs on how to generate the session

Checklist

• [ *] I've run bundle exec rspec from the root directory to see all new and existing tests pass
• [ *] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• [ *] I've read the Contribution Guidelines
• [* ] I've updated the documentation if necessary.

Motivation and Context

The "deploy to Heroku" button does not work if the iTunes connect account is configured for 2FA. This is because the FASTLANE_SESSION variable was not configured as an input variable for Heroku deployment, so it just fails. Existing solutions involve downloading the repo and "manually" deploying to Heroku, rendering the deploy to Heroku button useless.

#242

Description

Have added FASLTANE_SESSION and a description for this variable to app.json which is the file used to configure the heroku deploy. It's set as an optional variable.
Added this variable to the readme, on line 119 with a link to the docs that describes how to generate the session.

Testing Steps

I used this to deploy myself by opening up this link: https://www.heroku.com/deploy?template=https://github.com/coderbec/boarding/tree/2FA-enablement (this is what a deploy to Heroku button links to but configured for my fork)

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[coderbec]

Have signed a CLA now

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[janpio]

@googlebot I fixed it.

[janpio]

@googlebot does not seem convinced. Can you take a look @joshdholtz please?

[joshdholtz]

@coderbec Can you respond with @googlebot I signed it! That is needed to fix the CLA label 🙃

@janpio Can you respond with @googlebot I consent. after that? That should also fix the label with your additional commits

[coderbec]

@googlebot I signed it!

[coderbec]

btw I don't think any of the invitations from itunes connect are sending for the last few days due to Christmas shutdown. Have just realised they're not coming through. Might need to test again in a couple of days.

[janpio]

Seems @googlebot don't care @joshdholtz - maybe also on vacation for the holidays.

[avishayil]

Hi @coderbec I was trying to use your branch on Heroku, notice that iTunes connect password is still required, so I was wondering what to put in there...

[joshdholtz]

Looks good to me! Sorry for the late approval but I appreciate the contribution ❤️