This repository has been archived by the owner. It is now read-only.

fix issues with agent using wrong env during invocation #1101

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@snatchev
Contributor

snatchev commented Jul 25, 2018

  • I have run rspec and corrected all errors
  • I have run rubocop and corrected all errors
  • I have run npm run test and corrected all errors
  • I have tested this change locally and tried to launch the server as well as access a project, and with that at least one build

This PR fixes some issues encountered by the agent running bundle install. It was inheriting the bundle env from the agent's Gemfile... not the Gemfile under test.

Using Bundler.with_clean_env fixes the issue. Also includes some small fixes and refactors.

This PR supersedes #1091

@snatchev snatchev referenced this pull request Jul 25, 2018

Closed

expose port and host attrs. remove dead code #1091

4 of 4 tasks complete

@snatchev snatchev merged commit 41ae8c7 into master Jul 25, 2018

4 checks passed

cla/google All necessary CLAs are signed
coverage/coveralls First build on fixes-to-agent at 69.06%
Details
fastlane.ci: All rspecs pass All green
Details
fastlane.ci: All rubocops pass All green
Details

@snatchev snatchev deleted the fixes-to-agent branch Jul 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.