This repository has been archived by the owner. It is now read-only.

Added `foreman` gem to Gemfile for `:test, :development`. #1116

Merged
merged 3 commits into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@AndrewMcBurney
Member

AndrewMcBurney commented Aug 12, 2018

  • I have run rspec and corrected all errors
  • I have run rubocop and corrected all errors
  • I have run npm run test and corrected all errors
  • I have tested this change locally and tried to launch the server as well as access a project, and with that at least one build
  • If there is an existing issue, make sure to add Fixes ... as part of the PR body to reference the issue you're solving

Fixes #1114.

@AndrewMcBurney AndrewMcBurney requested review from fastlane/ci-backend as code owners Aug 12, 2018

Show outdated Hide outdated Gemfile Outdated
@taquitos

Given the warning from the foreman project, does it make sense for this change? Or should we instead have instructions on doing gem install foreman outside of the Gemfile? I'm just not familiar, at all, with foreman or best practices.

Show outdated Hide outdated Gemfile Outdated
@snatchev

This comment has been minimized.

Show comment
Hide comment
@snatchev

snatchev Aug 22, 2018

Contributor

@AndrewMcBurney I am unconvinced this is a good idea. Please see: #1088

If anything, this should be part of the dev_bootstrap process

Contributor

snatchev commented Aug 22, 2018

@AndrewMcBurney I am unconvinced this is a good idea. Please see: #1088

If anything, this should be part of the dev_bootstrap process

@taquitos

🎈🐐

@taquitos taquitos merged commit 5380491 into fastlane:master Aug 22, 2018

1 check passed

cla/google All necessary CLAs are signed

@AndrewMcBurney AndrewMcBurney deleted the AndrewMcBurney:add_foreman_to_dev branch Aug 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.