This repository has been archived by the owner. It is now read-only.

Status icons Component 馃寛 #720

Merged
merged 2 commits into from Apr 20, 2018

Conversation

Projects
None yet
2 participants
@nakhbari
Contributor

nakhbari commented Apr 20, 2018

Issue: #698

icons and colors subject to change, but now that's super easy with this modular component!

Desktop Screenshot

image

Mobile Screenshot

image

@@ -120,13 +120,13 @@
"directive-selector": [
true,
"attribute",
"app",
"fci",

This comment has been minimized.

@nakhbari

nakhbari Apr 20, 2018

Contributor

Had to change this so our prefix is specific to fastlane.ci (fci) not just app

@taquitos

This comment has been minimized.

Member

taquitos commented Apr 20, 2018

What do you think about using something more like a smily-face shrugging instead of the yellow smily? That way it better communicates that we don't know what the state is yet, because we're waiting for the build to be finished.

@nakhbari

This comment has been minimized.

Contributor

nakhbari commented Apr 20, 2018

@taquitos The icon types and colors will change. @chemichelle is working on it. This is just to get the infra in.

@taquitos

This comment has been minimized.

Member

taquitos commented Apr 20, 2018

Hawt. Love it.

sentiment_very_satisfied
</mat-icon>
<mat-icon *ngSwitchCase="BuildStatus.PENDING" class="fci-status-icon-pending">
sentiment_neutral

This comment has been minimized.

@taquitos

taquitos Apr 20, 2018

Member

sentiment_unknown might be better?

This comment has been minimized.

@taquitos

taquitos Apr 20, 2018

Member

ehh, maybe not. Yo no se

This comment has been minimized.

@nakhbari

nakhbari Apr 20, 2018

Contributor

These are all the strings provide by the material icon set https://material.io/icons/

sentiment_unknown isn't a provide icon.

@taquitos

馃幏馃悙

@nakhbari nakhbari merged commit a66f69f into master Apr 20, 2018

1 check passed

cla/google All necessary CLAs are signed

@nakhbari nakhbari deleted the icons branch Apr 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.