This repository has been archived by the owner. It is now read-only.

Added All the styles and form inputs for the add project dialog #770

Merged
merged 1 commit into from Apr 30, 2018

Conversation

Projects
None yet
2 participants
@nakhbari
Contributor

nakhbari commented Apr 28, 2018

Issue: #713

  • Added Dialog
  • Added Forms
  • Added styling
  • throw in the dialog going to fullscreen on mobile
  • Added Tests
  • Wire the close buttons to close the dialog
  • Wire the add project button to add project
  • Enable the add project endpoint to just use the repo full name
  • Add form data validation and errors

Desktop Screenshot

image

Mobile Screenshot

image

isAm: boolean;
}
function timeSelectDataToMilitaryTime(timeData: TimeSelectorData): number {

This comment has been minimized.

@KrauseFx

KrauseFx Apr 30, 2018

Member

Is this being decided based on the user agent?

This comment has been minimized.

@nakhbari

nakhbari Apr 30, 2018

Contributor

I'm not sure i understand the question. Could you expand on this?

Currently (i believe) our scheduled time is Hour+Minutes. So i believe we need 24 hour time format to work. This is why we do this conversation. So 12AM is 0, and 1pm is 13.

This comment has been minimized.

@KrauseFx

KrauseFx Apr 30, 2018

Member

Ahhh alright, sorry I misunderstood that code then

@nakhbari nakhbari merged commit 0efd594 into master Apr 30, 2018

3 checks passed

cla/google All necessary CLAs are signed
fastlane.ci: All rspecs pass All green
Details
fastlane.ci: All rubocops pass All green
Details

@KrauseFx KrauseFx deleted the project-dialog branch Apr 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.