This repository has been archived by the owner. It is now read-only.

Dockerfile updates #839

Merged
merged 1 commit into from May 10, 2018

Conversation

Projects
None yet
3 participants
@taquitos
Member

taquitos commented May 10, 2018

  • Switch to testing prod mode for now.
  • include node
  • update ruby version to 2.3 instead of 2.5
  • expose port 8080 by default

Fixes: #830
Although, note that it's running the rake task: hosted_prod_test not prod

Dockerfile updates
- Switch to testing prod mode for now.
- include node
- update ruby version to 2.3 instead of 2.5
- expose port 8080 by default
@@ -6,11 +6,15 @@ task :prod do
sh "bundle exec rackup -p 8080 --env production"
end
task :hosted_prod_test do
sh("FASTLANE_CI_ERB_CLIENT=1 DEBUG=1 FASTLANE_CI_DISABLE_REMOTE_STATUS_UPDATE=1 FASTLANE_CI_DISABLE_PUSHES=1 FASTLANE_CI_SKIP_RESTARTING_PENDING_WORK=1 bundle exec rackup --host 0.0.0.0 -p 8080 --env development")

This comment has been minimized.

@snatchev

snatchev May 10, 2018

Contributor

The env is development. Is that cool?

This comment has been minimized.

@taquitos

taquitos May 10, 2018

Member

Yeah, thanks for checking. Right now I'm doing a bunch of testing with this config and want to be using development as the env.

@snatchev

LGTM

@taquitos taquitos merged commit 1630ee3 into master May 10, 2018

3 checks passed

cla/google All necessary CLAs are signed
fastlane.ci: All rspecs pass All green
Details
fastlane.ci: All rubocops pass All green
Details

@taquitos taquitos deleted the docker_updates branch May 10, 2018

@@ -5,5 +5,6 @@ fastlane.log
fastlane.verbose.log
public/.dist/*
**/node_modules/*
node_modules

This comment has been minimized.

@KrauseFx

KrauseFx May 11, 2018

Member

My favorite folder isn't included 😢

This comment has been minimized.

@taquitos

taquitos May 11, 2018

Member

don't worry, you can run npm install and that will still download 85gb of pad-left dependencies.

This comment has been minimized.

@KrauseFx

KrauseFx May 12, 2018

Member

Beautiful

@@ -6,11 +6,15 @@ task :prod do
sh "bundle exec rackup -p 8080 --env production"
end
task :hosted_prod_test do
sh("FASTLANE_CI_ERB_CLIENT=1 DEBUG=1 FASTLANE_CI_DISABLE_REMOTE_STATUS_UPDATE=1 FASTLANE_CI_DISABLE_PUSHES=1 FASTLANE_CI_SKIP_RESTARTING_PENDING_WORK=1 bundle exec rackup --host 0.0.0.0 -p 8080 --env development")

This comment has been minimized.

@KrauseFx

KrauseFx May 14, 2018

Member

This is interesting, this fails bundle exec rubocop for me locally:

Rakefile:10:121: C: Metrics/LineLength: Line is too long. [215/120]

Anybody got an idea on why that is? Rubocop version is locked, and it should have failed this PR's build?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.