This repository has been archived by the owner. It is now read-only.

Support deployment using Vagrant #850

Merged
merged 9 commits into from May 16, 2018

Conversation

Projects
None yet
5 participants
@thii
Contributor

thii commented May 13, 2018

Since Docker does not support macOS guests, this allows deploying an isolated instance that can be used to build iOS projects.

brew install node
echo "==> Installing Bundler ..."
sudo gem install bundler -NV

This comment has been minimized.

@snatchev

snatchev May 14, 2018

Contributor

Is this sudo required?

This comment has been minimized.

@tkrajacic

tkrajacic May 14, 2018

That depends on if you are using rbenv?

This comment has been minimized.

@thii

thii May 14, 2018

Contributor

Yes, it is required on a fresh install of macOS where no Ruby version manager is installed.

This comment has been minimized.

@snatchev

snatchev May 14, 2018

Contributor

Okay as long as the vagrant user has password-less sudo, and I think the first time you sudo you get a prompt saying you agree to perform the action.

Alternatively, you can gem install --user-install bundler and make sure ~/.gem/ruby/2.3.0/bin is in the PATH

This comment has been minimized.

@snatchev

snatchev May 14, 2018

Contributor

Also, please use the long-form switches (e.g. --no-document) in scripts. It's much easier to read :)

This comment has been minimized.

@thii

thii May 14, 2018

Contributor

Done. PTAL.

@snatchev

This comment has been minimized.

Contributor

snatchev commented May 14, 2018

Thanks @thii! I am very much in favor of being able to use fastlane.ci via vagrant. I think this PR is great. I haven't been able to test it, because... I ran out of disk space downloading macOS! 😅

@snatchev

This comment has been minimized.

Contributor

snatchev commented May 14, 2018

@thii I was not able to complete the provision phase successfully.

During brew install I got:

    default: Software Update Tool
    default: ==> /usr/bin/sudo /bin/rm -f /tmp/.com.apple.dt.CommandLineTools.installondemand.in-progress
    default: ==> /usr/bin/sudo /usr/bin/xcode-select --switch /Library/Developer/CommandLineTools
    default: xcode-select: error: invalid developer directory '/Library/Developer/CommandLineTools'
    default: Failed during: /usr/bin/sudo /usr/bin/xcode-select --switch /Library/Developer/CommandLineTools
    default: /tmp/vagrant-shell: line 7: brew: command not found

Any ideas?

@thii

This comment has been minimized.

Contributor

thii commented May 15, 2018

The Homebrew install script failed when searching online for Command Line Tools.

https://github.com/Homebrew/install/blob/bbf4a3a8b247c7dba159c3d557cc3853dd764171/install#L262-L272

I've modified the script to retry if it fails.

@snatchev

Works for me! Thank you!

@thii

This comment has been minimized.

Contributor

thii commented May 16, 2018

Can we 🚢 this?

@snatchev

This comment has been minimized.

Contributor

snatchev commented May 16, 2018

@thii Yes! I need to figure out how to get these checks to pass, as it's blocking the merge button. Hang tight!

@taquitos taquitos requested a review from fastlane/team as a code owner May 16, 2018

@googlebot

This comment has been minimized.

googlebot commented May 16, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@taquitos

This is awesome, I'm working on getting the tests pass I'm sure you know, but it's not your fault 🎷🐐

@snatchev snatchev merged commit 83d7d42 into fastlane:master May 16, 2018

2 of 3 checks passed

cla/google CLAs are signed, but unable to verify author consent
fastlane.ci: All rspecs pass All green
Details
fastlane.ci: All rubocops pass All green
Details

@thii thii deleted the thii:vagrant branch May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.