This repository has been archived by the owner. It is now read-only.

Add coverage support for coveralls #900

Merged
merged 4 commits into from May 31, 2018

Conversation

Projects
None yet
3 participants
@minuscorp
Contributor

minuscorp commented May 21, 2018

  • Run tests fine.
    Use PhantomJS as testing browser
  • Test that actually pushes coverage reports to coveralls
=============================== Coverage summary ===============================
Statements   : 96.52% ( 527/546 )
Branches     : 63.11% ( 260/412 )
Functions    : 97.5% ( 117/120 )
Lines        : 98.93% ( 461/466 )
================================================================================
22 05 2018 20:59:33.358:INFO [coveralls.io]: uploading...
22 05 2018 20:59:33.359:INFO [coveralls.io]: 422 --- {"message":"Couldn't find a repository matching this job.","error":true}

@minuscorp minuscorp requested a review from fastlane/ci-frontend as a code owner May 21, 2018

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx May 21, 2018

Member

Would that work together with our Ruby based tests that also use Coveralls? Is Coveralls going to show it as one coverage?

Member

KrauseFx commented May 21, 2018

Would that work together with our Ruby based tests that also use Coveralls? Is Coveralls going to show it as one coverage?

@minuscorp

This comment has been minimized.

Show comment
Hide comment
@minuscorp

minuscorp May 21, 2018

Contributor

Those are questions that I have made for myself and couldn't figure out how to solve them. There's some kind of token or something to upload the report to coveralls or how does the platform manage it?

Contributor

minuscorp commented May 21, 2018

Those are questions that I have made for myself and couldn't figure out how to solve them. There's some kind of token or something to upload the report to coveralls or how does the platform manage it?

@minuscorp

This comment has been minimized.

Show comment
Hide comment
@minuscorp

minuscorp May 22, 2018

Contributor

From node-coveralls documentation:

This library currently supports travis-ci with no extra effort beyond piping the lcov output to coveralls. However, if you're using a different build system, there are a few environment variables that are necessary:

COVERALLS_SERVICE_NAME (the name of your build system)
COVERALLS_REPO_TOKEN (the secret repo token from coveralls.io)
There are optional environment variables for other build systems as well:

COVERALLS_SERVICE_JOB_ID (an id that uniquely identifies the build job)
COVERALLS_RUN_AT (a date string for the time that the job ran. RFC 3339 dates work. This defaults to your build system's date/time if you don't set it.)
COVERALLS_PARALLEL (more info here: https://coveralls.zendesk.com/hc/en-us/articles/203484329)

So I think we need to provide more information (that I cannot know at this point) to complete the deploy of the coverage results (I have confirmed that the reports are being created but it seems that are not being sent)

Contributor

minuscorp commented May 22, 2018

From node-coveralls documentation:

This library currently supports travis-ci with no extra effort beyond piping the lcov output to coveralls. However, if you're using a different build system, there are a few environment variables that are necessary:

COVERALLS_SERVICE_NAME (the name of your build system)
COVERALLS_REPO_TOKEN (the secret repo token from coveralls.io)
There are optional environment variables for other build systems as well:

COVERALLS_SERVICE_JOB_ID (an id that uniquely identifies the build job)
COVERALLS_RUN_AT (a date string for the time that the job ran. RFC 3339 dates work. This defaults to your build system's date/time if you don't set it.)
COVERALLS_PARALLEL (more info here: https://coveralls.zendesk.com/hc/en-us/articles/203484329)

So I think we need to provide more information (that I cannot know at this point) to complete the deploy of the coverage results (I have confirmed that the reports are being created but it seems that are not being sent)

@minuscorp minuscorp changed the title from [WIP] Add coverage support for coveralls to Add coverage support for coveralls May 22, 2018

Show outdated Hide outdated karma.conf.js Outdated

minuscorp added some commits May 21, 2018

@nakhbari nakhbari merged commit 385e54a into fastlane:master May 31, 2018

3 checks passed

cla/google All necessary CLAs are signed
fastlane.ci: All rspecs pass All green
Details
fastlane.ci: All rubocops pass All green
Details

@minuscorp minuscorp deleted the minuscorp:add-coverage-js branch May 31, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.