New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 10.1.0 fix #55

Merged
merged 5 commits into from Nov 22, 2018

Conversation

Projects
None yet
4 participants
@MartyCatawiki
Contributor

MartyCatawiki commented Nov 12, 2018

Since XCode 10.1.0 the 'scheme count' counts one scheme more then exists, but the check is not necessary at all, so it's removed.

This solves bug issue #54

Since XCode 10.1.0 the 'scheme count' counts one scheme more then exi…
…sts, but the check is not necessary at all, so it's removed
@googlebot

This comment has been minimized.

googlebot commented Nov 12, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@MartyCatawiki

This comment has been minimized.

Contributor

MartyCatawiki commented Nov 12, 2018

I signed it!

@googlebot

This comment has been minimized.

googlebot commented Nov 12, 2018

CLAs look good, thanks!

@MartyCatawiki

This comment has been minimized.

Contributor

MartyCatawiki commented Nov 14, 2018

@janpio Can you please merge this PR, so that we can use it with Xcode 10.1.0?

@janpio

This comment has been minimized.

Contributor

janpio commented Nov 14, 2018

Not my area, sorry. Could you take a look @powerivq please?

@powerivq

This comment has been minimized.

Contributor

powerivq commented Nov 14, 2018

@MartyCatawiki Hey, thanks for helping out! Can you provide a sample Xcode 10.1 xctestrun snippet for reference? If Apple changed its format, we would want to try update our logic to parse that, since test lab still can't have multiple schemes.

@MartyCatawiki

This comment has been minimized.

Contributor

MartyCatawiki commented Nov 15, 2018

@powerivq You're welcome!. This is my xctestrun snippet, in here you can see that since Xcode 10.1 an extra key is added, named __xctestrun_metadata__.

UITestingCatawiki_iphoneos12.1-arm64e.xctestrun.zip

@MartyCatawiki

This comment has been minimized.

Contributor

MartyCatawiki commented Nov 20, 2018

@janpio Could you please release my PR or continue on solving it differently for Xcode 10.1? I would really like to continue using this plugin, but it's holding up my CircleCI integration to go to Xcode 10.1

@janpio

This comment has been minimized.

Contributor

janpio commented Nov 20, 2018

As I said before, I can't do that - I am a commiter to fastlane, but this plugin here is @powerivq 's thing. Even if I merged this, I would have no way to release it. Sorry. @powerivq?

@MartyCatawiki

This comment has been minimized.

Contributor

MartyCatawiki commented Nov 20, 2018

As I said before, I can't do that - I am a commiter to fastlane, but this plugin here is @powerivq 's thing. Even if I merged this, I would have no way to release it. Sorry. @powerivq?

Sorry i typed your name @janpio again, i'm aware that you can't do that, my intention was to type @powerivq. Sorry for that!

So please @powerivq, could you release my PR or continue on solving it differently for Xcode 10.1? I would really like to continue using this plugin, but it's holding up my CircleCI integration to go to Xcode 10.1

@KrauseFx KrauseFx changed the title from XCode 10.1.0 fix to Xcode 10.1.0 fix Nov 20, 2018

@powerivq

This comment has been minimized.

Contributor

powerivq commented Nov 22, 2018

@MartyCatawiki Sorry for late reply, I was out on thanksgiving vacation. Looking at your sample, the new entry added is "xctestrun_metadata". I think the better test would be: Excluding "xctestrun_metadata", whether the number of entries is one.

@MartyCatawiki

This comment has been minimized.

Contributor

MartyCatawiki commented Nov 22, 2018

@powerivq Thanks for the replying now, i hope you enjoyed your holiday. I re-added the size-check again and counting one less when the key __xctestrun_metadata__ is found. Is this looking better?

@powerivq

This comment has been minimized.

Contributor

powerivq commented Nov 22, 2018

@MartyCatawiki Thanks for the revision! Except those nits, it all looks good!

@powerivq powerivq merged commit 685132e into fastlane:master Nov 22, 2018

1 check passed

cla/google All necessary CLAs are signed
@MartyCatawiki

This comment has been minimized.

Contributor

MartyCatawiki commented Nov 23, 2018

@powerivq Thanks for merging the Xcode 10.1.0 fix, when are you planning the release of 1.0.1?

@MartyCatawiki MartyCatawiki deleted the MartyCatawiki:xcode_10_1_0_fix branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment