Replace occurrences of “iTunes Connect” with “App Store Connect” (#12799

)

* Replace occurrences of “iTunes Connect” with “App Store Connect”

* fix test (description was too long)

* fix rubocop offenses

ToolsAndDebugging.md

@@ -56,8 +56,8 @@ _spaceship_ uses [Faraday](https://github.com/lostisland/faraday) to interact wi
 
 _spaceship_ is split into 3 layers:
 
-- `client.rb` which is the client superclass that contains all shared code between iTunes Connect the Developer Portal
-- `tunes_client.rb` and `portal_client.rb` which are the implementations for both iTunes Connect and Developer Portal. Those classes include the actual HTTP requests that are being sent:
+- `client.rb` which is the client superclass that contains all shared code between App Store Connect the Developer Portal
+- `tunes_client.rb` and `portal_client.rb` which are the implementations for both App Store Connect and Developer Portal. Those classes include the actual HTTP requests that are being sent:
 ```ruby
 def app_version_data(app_id, version_platform: nil, version_id: nil)
   r = request(:get, "ra/apps/#{app_id}/platforms/#{version_platform}/versions/#{version_id}")
@@ -70,8 +70,8 @@ Don’t use any custom HTML parsing in _spaceship_, instead try to only use JSON
 
 ### Verify the website works
 
-If _spaceship_ doesn’t work, it’s best to first find out if the actual website (Developer Portal or iTunes Connect) is currently working. Sometimes this might be a temporary server issue that gets resolved quickly. To gather information, make sure to check if other people are having the same issue on [GitHub](https://github.com/fastlane/fastlane/issues).
-If it is a server issue, it’s best to [file a radar](https://bugreport.apple.com/) or call the [iTunes Connect hotline](https://developer.apple.com/contact/phone/).
+If _spaceship_ doesn’t work, it’s best to first find out if the actual website (Developer Portal or App Store Connect) is currently working. Sometimes this might be a temporary server issue that gets resolved quickly. To gather information, make sure to check if other people are having the same issue on [GitHub](https://github.com/fastlane/fastlane/issues).
+If it is a server issue, it’s best to [file a radar](https://bugreport.apple.com/) or call the [App Store Connect hotline](https://developer.apple.com/contact/phone/).
 
 ### Setting up [Charles Web Proxy](https://www.charlesproxy.com/)
 
@@ -83,10 +83,10 @@ First, download and install the latest version of [Charles Proxy](https://www.ch
 
 > In Charles go to the Help menu and choose "SSL Proxying > Install Charles Root Certificate". Keychain Access will open, and prompt you about the certificate. Click the "Always Trust" button. You will then be prompted for your Administrator password to update the system trust settings.
 
-You might have to restart your Mac for the changes to be applied. To see if it works, relaunch Charles and Chrome/Safari and try opening [iTunes Connect](https://itunesconnect.apple.com).
+You might have to restart your Mac for the changes to be applied. To see if it works, relaunch Charles and Chrome/Safari and try opening [App Store Connect](https://itunesconnect.apple.com).
 
 If everything worked, you’ll already see a list of requests in the sidebar of Charles. Take a look at the above list of used API endpoints, and enable `SSL Proxying` and `Focus` on all endpoints you are interested in.
-After doing so, refresh the iTunes Connect page. You should be able to see all web requests with their responses.
+After doing so, refresh the App Store Connect page. You should be able to see all web requests with their responses.
 
 We’re not using the built-in network tracker of your browser, since we also need a proxy for our local _fastlane_ install, which will be covered in the next section of this document.
 

VISION.md

@@ -27,9 +27,9 @@ Each _fastlane_ tool has a specific purpose and should be kept focused on the fu
 * [_frameit_](https://github.com/fastlane/fastlane/tree/master/frameit): Quickly put your screenshots into the right device frames
 * [_pem_](https://github.com/fastlane/fastlane/tree/master/pem): Automatically generate and renew your push notification certificates
 * [_sigh_](https://github.com/fastlane/fastlane/tree/master/sigh): Because you would rather spend your time building stuff than fighting provisioning
-* [_produce_](https://github.com/fastlane/fastlane/tree/master/produce): Create new iOS apps on iTunes Connect and Apple Developer Portal using the command line
+* [_produce_](https://github.com/fastlane/fastlane/tree/master/produce): Create new iOS apps on App Store Connect and Apple Developer Portal using the command line
 * [_cert_](https://github.com/fastlane/fastlane/tree/master/cert): Automatically create and maintain iOS code signing certificates
-* [_spaceship_](https://github.com/fastlane/fastlane/tree/master/spaceship): Ruby library to access the Apple Developer Portal and iTunes Connect
+* [_spaceship_](https://github.com/fastlane/fastlane/tree/master/spaceship): Ruby library to access the Apple Developer Portal and App Store Connect
 * [_pilot_](https://github.com/fastlane/fastlane/tree/master/pilot): The best way to manage your TestFlight testers and builds from your terminal
 * [boarding](https://github.com/fastlane/boarding): The easiest way to invite your TestFlight beta testers
 * [_gym_](https://github.com/fastlane/fastlane/tree/master/gym): Building your iOS apps has never been easier

credentials_manager/lib/credentials_manager/appfile_config.rb

@@ -110,7 +110,7 @@ def team_name(*args, &block)
       setter(:team_name, *args, &block)
     end
 
-    # iTunes Connect
+    # App Store Connect
     def itc_team_id(*args, &block)
       setter(:itc_team_id, *args, &block)
     end

deliver/lib/assets/DeliverfileDefault

@@ -1,3 +1,3 @@
-# The Deliverfile allows you to store various iTunes Connect metadata
+# The Deliverfile allows you to store various App Store Connect metadata
 # For more information, check out the docs
 # https://docs.fastlane.tools/actions/deliver/

deliver/lib/assets/DeliverfileDefault.swift

@@ -1,3 +1,3 @@
-// The Deliverfile allows you to store various iTunes Connect metadata
+// The Deliverfile allows you to store various App Store Connect metadata
 // For more information, check out the docs
 // https://docs.fastlane.tools/actions/deliver/

deliver/lib/assets/summary.html.erb

@@ -250,7 +250,7 @@
                 <% if options[:overwrite_screenshots] %>
                   <b>--overwrite_screenshots</b> is set, existing screenshots will be removed, but none will be uploaded.
                 <% else %>
-                  The existing screenshots on iTunes Connect will be kept. 
+                  The existing screenshots on App Store Connect will be kept. 
                   if you want to remove them you have to use the <i>--overwrite_screenshots</i> flag.
                 <% end %>
               <p>

deliver/lib/deliver/commands_generator.rb

@@ -55,7 +55,7 @@ def run
 
       command :run do |c|
         c.syntax = 'fastlane deliver'
-        c.description = 'Upload metadata and binary to iTunes Connect'
+        c.description = 'Upload metadata and binary to App Store Connect'
 
         FastlaneCore::CommanderGenerator.new.generate(deliverfile_options, command: c)
 
@@ -135,7 +135,7 @@ def run
 
       command :download_screenshots do |c|
         c.syntax = 'fastlane deliver download_screenshots'
-        c.description = "Downloads all existing screenshots from iTunes Connect and stores them in the screenshots folder"
+        c.description = "Downloads all existing screenshots from App Store Connect and stores them in the screenshots folder"
 
         FastlaneCore::CommanderGenerator.new.generate(deliverfile_options, command: c)
 

deliver/lib/deliver/detect_values.rb

@@ -42,7 +42,7 @@ def find_app(options)
       if app
         options[:app] = app
       else
-        UI.user_error!("Could not find app with app identifier '#{options[:app_identifier]}' in your iTunes Connect account (#{options[:username]} - Team: #{Spaceship::Tunes.client.team_id})")
+        UI.user_error!("Could not find app with app identifier '#{options[:app_identifier]}' in your App Store Connect account (#{options[:username]} - Team: #{Spaceship::Tunes.client.team_id})")
       end
     end
 

deliver/lib/deliver/download_screenshots.rb

@@ -8,7 +8,7 @@ def self.run(options, path)
       UI.success("Successfully downloaded all existing screenshots")
     rescue => ex
       UI.error(ex)
-      UI.error("Couldn't download already existing screenshots from iTunes Connect.")
+      UI.error("Couldn't download already existing screenshots from App Store Connect.")
     end
 
     def self.download(options, folder_path)

deliver/lib/deliver/options.rb

@@ -89,7 +89,7 @@ def self.available_options
                                      description: "Path to the folder containing the screenshots",
                                      optional: true),
         FastlaneCore::ConfigItem.new(key: :skip_binary_upload,
-                                     description: "Skip uploading an ipa or pkg to iTunes Connect",
+                                     description: "Skip uploading an ipa or pkg to App Store Connect",
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :use_live_version,
@@ -175,7 +175,7 @@ def self.available_options
         FastlaneCore::ConfigItem.new(key: :team_id,
                                      short_option: "-k",
                                      env_name: "DELIVER_TEAM_ID",
-                                     description: "The ID of your iTunes Connect team if you're in multiple teams",
+                                     description: "The ID of your App Store Connect team if you're in multiple teams",
                                      optional: true,
                                      is_string: false, # as we also allow integers, which we convert to strings anyway
                                      code_gen_sensitive: true,
@@ -187,7 +187,7 @@ def self.available_options
         FastlaneCore::ConfigItem.new(key: :team_name,
                                      short_option: "-e",
                                      env_name: "DELIVER_TEAM_NAME",
-                                     description: "The name of your iTunes Connect team if you're in multiple teams",
+                                     description: "The name of your App Store Connect team if you're in multiple teams",
                                      optional: true,
                                      code_gen_sensitive: true,
                                      default_value: CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_name),

deliver/lib/deliver/runner.rb

@@ -27,7 +27,7 @@ def initialize(options, skip_auto_detection = {})
     end
 
     def login
-      UI.message("Login to iTunes Connect (#{options[:username]})")
+      UI.message("Login to App Store Connect (#{options[:username]})")
       Spaceship::Tunes.login(options[:username])
       Spaceship::Tunes.select_team
       UI.message("Login successful")
@@ -42,7 +42,7 @@ def run
         upload_binary
       end
 
-      UI.success("Finished the upload to iTunes Connect") unless options[:skip_binary_upload]
+      UI.success("Finished the upload to App Store Connect") unless options[:skip_binary_upload]
 
       reject_version_if_possible if options[:reject_if_possible]
 
@@ -83,22 +83,22 @@ def precheck_app
       return precheck_success
     end
 
-    # Make sure the version on iTunes Connect matches the one in the ipa
+    # Make sure the version on App Store Connect matches the one in the ipa
     # If not, the new version will automatically be created
     def verify_version
       app_version = options[:app_version]
-      UI.message("Making sure the latest version on iTunes Connect matches '#{app_version}' from the ipa file...")
+      UI.message("Making sure the latest version on App Store Connect matches '#{app_version}' from the ipa file...")
 
       changed = options[:app].ensure_version!(app_version, platform: options[:platform])
 
       if changed
         UI.success("Successfully set the version to '#{app_version}'")
       else
-        UI.success("'#{app_version}' is the latest version on iTunes Connect")
+        UI.success("'#{app_version}' is the latest version on App Store Connect")
       end
     end
 
-    # Upload all metadata, screenshots, pricing information, etc. to iTunes Connect
+    # Upload all metadata, screenshots, pricing information, etc. to App Store Connect
     def upload_metadata
       upload_metadata = UploadMetadata.new
       upload_screenshots = UploadScreenshots.new
@@ -137,9 +137,9 @@ def prepare_app_icons(options = {})
       options[:apple_watch_app_icon] ||= default_watch_icon_path if default_watch_icon_path && File.exist?(default_watch_icon_path)
     end
 
-    # Upload the binary to iTunes Connect
+    # Upload the binary to App Store Connect
     def upload_binary
-      UI.message("Uploading binary to iTunes Connect")
+      UI.message("Uploading binary to App Store Connect")
       if options[:ipa]
         package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(
           app_id: options[:app].apple_id,
@@ -158,7 +158,7 @@ def upload_binary
 
       transporter = FastlaneCore::ItunesTransporter.new(options[:username], nil, false, options[:itc_provider])
       result = transporter.upload(options[:app].apple_id, package_path)
-      UI.user_error!("Could not upload binary to iTunes Connect. Check out the error above", show_github_issues: true) unless result
+      UI.user_error!("Could not upload binary to App Store Connect. Check out the error above", show_github_issues: true) unless result
     end
 
     def reject_version_if_possible

deliver/lib/deliver/submit_for_review.rb

@@ -60,10 +60,10 @@ def wait_for_build(app)
         build = find_build(app.latest_version.candidate_builds)
         return build if build.processing == false
 
-        UI.message("Waiting iTunes Connect processing for build #{build.train_version} (#{build.build_version})... this might take a while...")
+        UI.message("Waiting App Store Connect processing for build #{build.train_version} (#{build.build_version})... this might take a while...")
         if (Time.now - start) > (60 * 5)
           UI.message("")
-          UI.message("You can tweet: \"iTunes Connect #iosprocessingtime #{((Time.now - start) / 60).round} minutes\"")
+          UI.message("You can tweet: \"App Store Connect #iosprocessingtime #{((Time.now - start) / 60).round} minutes\"")
         end
         sleep(30)
       end
@@ -72,7 +72,7 @@ def wait_for_build(app)
 
     def find_build(candidate_builds)
       if (candidate_builds || []).count == 0
-        UI.user_error!("Could not find any available candidate builds on iTunes Connect to submit")
+        UI.user_error!("Could not find any available candidate builds on App Store Connect to submit")
       end
 
       build = candidate_builds.first

deliver/lib/deliver/upload_metadata.rb

@@ -81,7 +81,7 @@ def upload(options)
         non_localised_options = NON_LOCALISED_LIVE_VALUES
 
         if v.nil?
-          UI.message("Couldn't find live version, editing the current version on iTunes Connect instead")
+          UI.message("Couldn't find live version, editing the current version on App Store Connect instead")
           v = app.edit_version(platform: options[:platform])
           # we don't want to update the localised_options and non_localised_options
           # as we also check for `options[:edit_live]` at other areas in the code
@@ -126,12 +126,12 @@ def upload(options)
       set_review_information(v, options)
       set_app_rating(v, options)
 
-      Helper.show_loading_indicator("Uploading metadata to iTunes Connect")
+      Helper.show_loading_indicator("Uploading metadata to App Store Connect")
       v.save!
       Helper.hide_loading_indicator
       begin
         details.save!
-        UI.success("Successfully uploaded set of metadata to iTunes Connect")
+        UI.success("Successfully uploaded set of metadata to App Store Connect")
       rescue Spaceship::TunesClient::ITunesConnectError => e
         # This makes sure that we log invalid app names as user errors
         # If another string needs to be checked here we should

deliver/lib/deliver/upload_screenshots.rb

@@ -5,7 +5,7 @@
 require_relative 'loader'
 
 module Deliver
-  # upload screenshots to iTunes Connect
+  # upload screenshots to App Store Connect
   class UploadScreenshots
     def upload(options, screenshots)
       return if options[:skip_screenshots]
@@ -75,7 +75,7 @@ def upload(options, screenshots)
         v = app.edit_version
         Helper.hide_loading_indicator
       end
-      UI.success("Successfully uploaded screenshots to iTunes Connect")
+      UI.success("Successfully uploaded screenshots to App Store Connect")
     end
 
     def collect_screenshots(options)

deliver/spec/submit_for_review_spec.rb

@@ -26,7 +26,7 @@ def make_fake_builds(number_of_builds)
       it 'throws a UI error' do
         expect do
           review_submitter.find_build(fake_builds)
-        end.to raise_error(FastlaneCore::Interface::FastlaneError, "Could not find any available candidate builds on iTunes Connect to submit")
+        end.to raise_error(FastlaneCore::Interface::FastlaneError, "Could not find any available candidate builds on App Store Connect to submit")
       end
     end
 

fastlane/lib/fastlane/actions/app_store_build_number.rb

@@ -19,7 +19,7 @@ def self.run(params)
       end
 
       def self.get_build_number(params)
-        UI.message("Login to iTunes Connect (#{params[:username]})")
+        UI.message("Login to App Store Connect (#{params[:username]})")
         Spaceship::Tunes.login(params[:username])
         Spaceship::Tunes.select_team
         UI.message("Login successful")
@@ -105,7 +105,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :team_id,
                                        short_option: "-k",
                                        env_name: "APPSTORE_BUILD_NUMBER_LIVE_TEAM_ID",
-                                       description: "The ID of your iTunes Connect team if you're in multiple teams",
+                                       description: "The ID of your App Store Connect team if you're in multiple teams",
                                        optional: true,
                                        is_string: false, # as we also allow integers, which we convert to strings anyway
                                        code_gen_sensitive: true,
@@ -138,7 +138,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :team_name,
                                        short_option: "-e",
                                        env_name: "LATEST_TESTFLIGHT_BUILD_NUMBER_TEAM_NAME",
-                                       description: "The name of your iTunes Connect team if you're in multiple teams",
+                                       description: "The name of your App Store Connect team if you're in multiple teams",
                                        optional: true,
                                        code_gen_sensitive: true,
                                        default_value: CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_name),

fastlane/lib/fastlane/actions/create_app_online.rb

@@ -27,7 +27,7 @@ def self.description
 
       def self.details
         [
-          "Create new apps on iTunes Connect and Apple Developer Portal via _produce_.",
+          "Create new apps on App Store Connect and Apple Developer Portal via _produce_.",
           "If the app already exists, `create_app_online` will not do anything.",
           "For more information about _produce_, visit its documentation page: [https://docs.fastlane.tools/actions/produce/](https://docs.fastlane.tools/actions/produce/)."
         ].join("\n")