From 23ea7c0d44de915722ffa77d188a2fa3c220a5ef Mon Sep 17 00:00:00 2001 From: Lorenzo Mattei Date: Mon, 28 Aug 2023 23:48:35 +0200 Subject: [PATCH] Add comments to explain the fallback --- deliver/lib/deliver/upload_metadata.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/deliver/lib/deliver/upload_metadata.rb b/deliver/lib/deliver/upload_metadata.rb index fd80227c02b..84a3d5b8ae2 100644 --- a/deliver/lib/deliver/upload_metadata.rb +++ b/deliver/lib/deliver/upload_metadata.rb @@ -222,6 +222,11 @@ def upload(options) app_info_worker.start # Update categories + # When there are iOS and macOS implementations of the same app, + # fetch_edit_app_info will fail when trying to fetch data for one platform + # if the other is in not editable state. + # We still keep fetch_edit_app_info as first option to make sure + # latest data is fetched when apps are in an editable state. app_info = fetch_edit_app_info(app) || fetch_live_app_info(app) if app_info category_id_map = {} @@ -459,6 +464,11 @@ def retry_if_nil(message, tries: 5, wait_time: 10) # Finding languages to enable def verify_available_info_languages!(options, app, languages) + # When there are iOS and macOS implementations of the same app, + # fetch_edit_app_info will fail when trying to fetch data for one platform + # if the other is in not editable state. + # We still keep fetch_edit_app_info as first option to make sure + # latest data is fetched when apps are in an editable state. app_info = fetch_edit_app_info(app) || fetch_live_app_info(app) unless app_info