diff --git a/frameit/lib/frameit/editor.rb b/frameit/lib/frameit/editor.rb index c2511616960..0d875cd9fac 100644 --- a/frameit/lib/frameit/editor.rb +++ b/frameit/lib/frameit/editor.rb @@ -439,7 +439,7 @@ def build_text_images(max_width, max_height) results[key] = text_image - # Natively trimming the image with .trim will result in the loss of the common baseline between the text in all images when side-by-side (e.g. stack_title is false). + # Natively trimming the image with .trim will result in the loss of the common baseline between the text in all images when side-by-side. # Hence retrieve the calculated trim bounding box without actually trimming: calculated_trim_box = text_image.identify do |b| b.format("%@") # CALCULATED: trim bounding box (without actually trimming), see: http://www.imagemagick.org/script/escape.php diff --git a/snapshot/lib/snapshot/setup.rb b/snapshot/lib/snapshot/setup.rb index fd384f819d5..b7cb7c795c9 100644 --- a/snapshot/lib/snapshot/setup.rb +++ b/snapshot/lib/snapshot/setup.rb @@ -19,7 +19,7 @@ def self.create(path, is_swift_fastfile: false, print_instructions_on_failure: f if File.exist?(snapfile_path) if print_instructions_on_failure - print_instructions(snapshot_helper_filename: snapshot_helper_filename, snapfile_path: snapfile_path) + print_instructions(snapshot_helper_filename: snapshot_helper_filename) return else UI.user_error!("Snapfile already exists at path '#{snapfile_path}'. Run 'fastlane snapshot' to generate screenshots.") @@ -37,7 +37,7 @@ def self.create(path, is_swift_fastfile: false, print_instructions_on_failure: f print_instructions(snapshot_helper_filename: snapshot_helper_filename, snapfile_path: snapfile_path) end - def self.print_instructions(snapshot_helper_filename: nil, snapfile_path: nil) + def self.print_instructions(snapshot_helper_filename: nil) puts("Open your Xcode project and make sure to do the following:".yellow) puts("1) Add a new UI Test target to your project".yellow) puts("2) Add the ./fastlane/#{snapshot_helper_filename} to your UI Test target".yellow)