Duplicate swiftlint custom executable parameter, so it doesn't get co…

…rrupted (#9535)

* Duplicate the executable reference, so it doesn't get corrupted

* Formatting inprovements from peer review

fastlane/lib/fastlane/actions/swiftlint.rb

@@ -11,7 +11,7 @@ def self.run(params)
           UI.user_error!("Your version of swiftlint (#{version}) does not support autocorrect mode.\nUpdate swiftlint using `brew update && brew upgrade swiftlint`")
         end
 
-        command = params[:executable].nil? ? "swiftlint" : params[:executable]
+        command = (params[:executable] || "swiftlint").dup
         command << " #{params[:mode]}"
         command << supported_option_switch(params, :strict, "0.9.2", true)
         command << " --config #{params[:config_file].shellescape}" if params[:config_file]
@@ -39,7 +39,7 @@ def self.run(params)
 
       # Get current SwiftLint version
       def self.swiftlint_version(executable: nil)
-        binary = executable.nil? ? 'swiftlint' : executable
+        binary = executable || 'swiftlint'
         Gem::Version.new(`#{binary} version`.chomp)
       end
 

fastlane/spec/actions_specs/swiftlint_spec.rb

@@ -29,6 +29,26 @@
 
           expect(result).to eq("swiftlint lint --strict")
         end
+
+        it "adds strict option for custom executable" do
+          CUSTOM_EXECUTABLE_NAME = "custom_executable"
+
+          # Override the already overridden swiftlint_version method to check
+          # that the correct exectuable is being passed in as a parameter.
+          allow(Fastlane::Actions::SwiftlintAction).to receive(:swiftlint_version) { |params|
+            expect(params[:executable]).to eq(CUSTOM_EXECUTABLE_NAME)
+            swiftlint_gem_version
+          }
+
+          result = Fastlane::FastFile.new.parse("lane :test do
+            swiftlint(
+              strict: true,
+              executable: '#{CUSTOM_EXECUTABLE_NAME}'
+            )
+          end").runner.execute(:test)
+
+          expect(result).to eq("#{CUSTOM_EXECUTABLE_NAME} lint --strict")
+        end
       end
 
       context "when specify false for strict option" do