Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match doesn't renew the signing certificate automatically after the certificate expires #11663

Closed
VirtualFox0 opened this issue Jan 23, 2018 · 25 comments

Comments

Projects
None yet
@VirtualFox0
Copy link

commented Jan 23, 2018

New Issue Checklist

Issue Description

An expired signing certificate is automatically removed from the Apple Developer Center. After the expiring date match breaks with the following error:

[13:08:23]: Certificate 'xyz' (stored in your git repo) is not available on the Developer Portal  
[13:08:23]: for the user xyz  
[13:08:23]: Make sure to use the same user and team every time you run 'match' for this  
[13:08:23]: Git repository. This might be caused by revoking the certificate on the Dev Portal

I used fastlane with version 2.77.1.

Expected Behaviour

match automatically recreates signing certificates if they don't exist and regenerates corresponding provisioning profiles etc. This includes certificate expiration and deletion/revoke in the development center.

@fastlane-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

It seems like this issue might be related to code signing 🚫

Have you seen our new Code Signing Troubleshooting Guide? It will help you resolve the most common code signing issues 👍

@fastlane-bot

This comment has been minimized.

Copy link

commented Jan 23, 2018

It seems like you have not included the output of fastlane env

To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env 👍

@KrauseFx

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

Do you remember, did this work in the past for you, or did no certificate expire before?

@VirtualFox0

This comment has been minimized.

Copy link
Author

commented Jan 23, 2018

This is the first expiring certificate since we are using match.

@fastlane-bot

This comment has been minimized.

Copy link

commented Mar 9, 2018

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@danilobuerger

This comment has been minimized.

Copy link

commented Mar 20, 2018

Same issue, using --force doesn't seem to work, had to resort to nuke :(

@alexmaslov

This comment has been minimized.

Copy link

commented Apr 4, 2018

Same issue. expiring certificates don't get renewed, but remain in the match repo until manually removed.

@robmaceachern

This comment has been minimized.

Copy link
Contributor

commented May 4, 2018

This is still an issue for me on Fastlane 2.94.0

@fastlane fastlane deleted a comment from fastlane-bot May 6, 2018

@joshdholtz

This comment has been minimized.

Copy link
Member

commented May 6, 2018

Will add this to my list of things to look into 🙃

Sent with GitHawk

@bbernberg

This comment has been minimized.

Copy link

commented May 9, 2018

Warby Parker developer here -- we would love to see this feature as well!

@mbuchetics

This comment has been minimized.

Copy link

commented Jul 2, 2018

We just experienced this issue as well.

@fastlane-bot

This comment has been minimized.

Copy link

commented Aug 2, 2018

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@mbuchetics

This comment has been minimized.

Copy link

commented Aug 2, 2018

This is not fixed, this is still happening. What activity do you want, @fastlane-bot ??

@garylai

This comment has been minimized.

Copy link

commented Aug 16, 2018

Instead of just select the last cert in the directory: https://github.com/fastlane/fastlane/blob/master/match/lib/match/runner.rb#L106
maybe it can loop through the certs and select the first one that is not expired? And if it cannot find one then generate a new cert?

@fastlane-bot

This comment has been minimized.

Copy link

commented Sep 15, 2018

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@peterromfeldhk

This comment has been minimized.

Copy link

commented Sep 20, 2018

we just got a email that our cert will expire in 30 days, i looked but there is no documentation for cert renewal using match. i guess the workaround would be to a nuke if it doesn't renew/recreate it

@ngreeney

This comment has been minimized.

Copy link

commented Oct 19, 2018

Running into the same issue here. Might resort to killing out repo and trying to get match to start over with a clean slate.

@eimantas

This comment has been minimized.

Copy link

commented Oct 31, 2018

We just hit this same issue. We're considering the nuke option as the response doesn't look like happening in the nearest future and we can't wait with the release train.

@mbuchetics

This comment has been minimized.

Copy link

commented Nov 9, 2018

This is still a major issue and we just ran into it again ... certificate expired but it's not getting renewed.

@ngreeney

This comment has been minimized.

Copy link

commented Nov 9, 2018

@eimantas and @mbuchetics - Still an issue for me as well but my work around for it was to manually delete the certificate on developer.apple.com and then deleted the repo that Match was using. Then made sure all the Match commands had the Force which recreated the cert as well as new provisioning profiles to match the cert.

Would be nice if this was done by Match rather than needing to get into a clean slate for this to work though.

@mbuchetics

This comment has been minimized.

Copy link

commented Nov 12, 2018

@ngreeney I only had to delete the certificate files in the repository and it worked again.

@Felipe-Banno

This comment has been minimized.

Copy link

commented Nov 21, 2018

We are also having this issue. Any plans to fix it?

@joshdholtz

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Heyyyyy! I just answered this over here - #10724 (comment)

If you would like to let me know your thoughts on my suggestion for this that would be 💯

@fastlane-bot

This comment has been minimized.

Copy link

commented Dec 22, 2018

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@fastlane-bot

This comment has been minimized.

Copy link

commented Jan 1, 2019

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍

@fastlane fastlane locked and limited conversation to collaborators Mar 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.