New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom_args support not working any more in Snapfile #4717

Closed
funkenstrahlen opened this Issue May 18, 2016 · 9 comments

Comments

Projects
None yet
4 participants
@funkenstrahlen

funkenstrahlen commented May 18, 2016

New Issue Checklist

Issue Description

I use custom_args "GCC_PREPROCESSOR_DEFINITIONS='SCREENSHOTS'" in my Snapfile to build a version perfectly to generate screenshots.

This does not work any more now. I tried using custom_build_args however it does not work too.

Complete output when running fastlane, including the stack trace and command used
➜  xenim-ios-app git:(release/1.2) ✗ fastlane screenshots
[18:56:57]: -------------------------------------------------
[18:56:57]: --- Step: Verifying required fastlane version ---
[18:56:57]: -------------------------------------------------
[18:56:57]: fastlane version valid
[18:56:57]: ------------------------------
[18:56:57]: --- Step: default_platform ---
[18:56:57]: ------------------------------
[18:56:57]: Driving the lane 'ios screenshots' 🚀
[18:56:57]: -----------------------------
[18:56:57]: --- Step: update_fastlane ---
[18:56:57]: -----------------------------
[18:56:57]: Looking for updates for cert, credentials_manager, deliver, fastlane, fastlane_core, frameit, gym, match, pem, pilot, produce, scan, screengrab, sigh, snapshot, spaceship, supply...
[18:57:03]: Nothing to update ✅
[18:57:03]: ----------------------
[18:57:03]: --- Step: snapshot ---
[18:57:03]: ----------------------
[18:57:04]: Variable Dump:
[18:57:04]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios screenshots"}
[18:57:04]: Could not find option 'custom_build_args' in the list of available options: workspace, project, devices, languages, launch_arguments, output_directory, ios_version, skip_open_summary, clear_previous_screenshots, reinstall_app, erase_simulator, localize_simulator, app_identifier, add_photos, add_videos, buildlog_path, clean, configuration, xcpretty_args, sdk, scheme, number_of_retries, stop_after_first_error, derived_data_path

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | update_fastlane                     | 6           |
| 4    | snapshot                            | 0           |
+------+-------------------------------------+-------------+

[18:57:04]: fastlane finished with errors

[!] Could not find option 'custom_build_args' in the list of available options: workspace, project, devices, languages, launch_arguments, output_directory, ios_version, skip_open_summary, clear_previous_screenshots, reinstall_app, erase_simulator, localize_simulator, app_identifier, add_photos, add_videos, buildlog_path, clean, configuration, xcpretty_args, sdk, scheme, number_of_retries, stop_after_first_error, derived_data_path

Configuration Files

Please copy the complete content of your Fastfile and any other configuration files you use below:

Fastfile:

  desc "Generate screenshots for all supported devices"
  lane :screenshots do 
    snapshot(configuration: "Debug")

    # currently frameit not required
    # frameit
  end

Environment

fastlane version (run fastlane -v): fastlane 1.89.0

Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? No.

Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? rbenv

@TKBurner

This comment has been minimized.

TKBurner commented May 19, 2016

@funkenstrahlen Thanks for reaching out. Right now we don't support this. I'll mark this as a feature request since the launch_arguments parameter doesn't cover your use case. I'm going to mark this as help wanted in case anyone from the community wants to take a look 👍

@funkenstrahlen

This comment has been minimized.

funkenstrahlen commented May 19, 2016

So why did this feature get removed? Or did it not work before and it just did not throw an error?

@TKBurner

This comment has been minimized.

TKBurner commented May 20, 2016

Hi @funkenstrahlen Thanks for asking this was retired in favor of launch arguments and xcpretty arguments. I'll leave this ticket open because I'm curious to know if anyone else is trying to do this 👍

@funkenstrahlen

This comment has been minimized.

funkenstrahlen commented May 28, 2016

I am open to alternatives. I have only one usecase: There is a framework changing the look of the statusbar in the simulator, so I can generate nice screenshots via snapshot. This framework does access Apple private API though, so I can not ship it to iTunes Connect. I want the framework only to be linked if I run snapshot.

@TKBurner

This comment has been minimized.

TKBurner commented May 31, 2016

@funkenstrahlen Thanks for following up. What happens if you link the framework to it's own test target in Xcode and then setup snapshot on that test target?

@Sef1995

This comment has been minimized.

Sef1995 commented Jul 30, 2016

@funkenstrahlen Have you found a solution for this problem? Because I'm also looking for a solution.

@TKBurner TKBurner self-assigned this Aug 12, 2016

@TKBurner

This comment has been minimized.

TKBurner commented Aug 12, 2016

Hi @Sef1995! Thanks for followin gup on this. Can you provide your full input and output? I'd love to take a look.

@fastlane-bot

This comment has been minimized.

fastlane-bot commented Oct 11, 2016

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@fastlane-bot

This comment has been minimized.

fastlane-bot commented Oct 20, 2016

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍

@fastlane fastlane locked and limited conversation to collaborators Jan 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.