Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match should not call sigh with force: true #5667

Closed
2 tasks done
richardszalay opened this issue Aug 9, 2016 · 9 comments
Closed
2 tasks done

Match should not call sigh with force: true #5667

richardszalay opened this issue Aug 9, 2016 · 9 comments

Comments

@richardszalay
Copy link

@richardszalay richardszalay commented Aug 9, 2016

New Issue Checklist

Issue Description

馃攽 If a profile can't be found on the repository, match calls sigh with force: true. With this flag set, sigh will add all devices to the profile, which may not be what the user wanted.

(I also think that force_for_new_devices should be comparing the local/remote profile devices count, rather than comparing the local profile device count to the total number of devices on the portal)

Environment

fastlane version (run fastlane -v): 1.99.0

Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? Yes

Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? No

@KrauseFx
Copy link
Member

@KrauseFx KrauseFx commented Aug 9, 2016

Interesting, thanks @richardszalay 馃憤 What's the reason you don't want all devices to be included? Just curios about the use-case

Loading

@richardszalay
Copy link
Author

@richardszalay richardszalay commented Aug 9, 2016

Essentially one "Portal Team" doesn't represent every user for every app. Different apps have different "sets" of users (that we're happy to maintain ourselves in the portal).

Loading

@fastlane-bot
Copy link

@fastlane-bot fastlane-bot commented Oct 9, 2016

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 馃憤

Loading

@richardszalay
Copy link
Author

@richardszalay richardszalay commented Oct 9, 2016

This hasn't been resolved by a newer release.

Loading

@TKBurner
Copy link

@TKBurner TKBurner commented Oct 11, 2016

@richardszalay Thanks for following up. I'm going to mark this as a feature request and open it up to PRs. I think this would make more sense as an option than a default. What do you think?

Loading

@fastlane-bot
Copy link

@fastlane-bot fastlane-bot commented Dec 19, 2016

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 馃憤

Loading

@richardszalay
Copy link
Author

@richardszalay richardszalay commented Dec 20, 2016

@TKBurner I think that sounds like a great idea. I'll do it myself, if I ever get a spare moment ;)

Loading

@fastlane-bot
Copy link

@fastlane-bot fastlane-bot commented Feb 27, 2017

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 馃憤

Loading

@fastlane-bot
Copy link

@fastlane-bot fastlane-bot commented Mar 8, 2017

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 馃憤

Loading

@fastlane fastlane locked and limited conversation to collaborators Jun 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants