Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supported platform of pilot, and testflight action #10253

Merged
merged 2 commits into from Sep 5, 2017
Merged

Fix supported platform of pilot, and testflight action #10253

merged 2 commits into from Sep 5, 2017

Conversation

taisukeh
Copy link
Contributor

@taisukeh taisukeh commented Sep 5, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

The pilot action doesn't support android platform. I think it would be misleading.

image

Description

This change alos affects the testflight action.
https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/testflight.rb#L39

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nice catch, thanks for the PR 👍 I think it also doesn't support macOS, right? It's only iOS

@taisukeh
Copy link
Contributor Author

taisukeh commented Sep 5, 2017

Right, fixed, thanks :)

@KrauseFx KrauseFx merged commit be449b0 into fastlane:master Sep 5, 2017
@KrauseFx
Copy link
Member

KrauseFx commented Sep 5, 2017

Awesome, thanks 👍

@fastlane-bot
Copy link

Hey @taisukeh 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.56.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Nov 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants