New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring metrics to be more understandable #10488

Merged
merged 80 commits into from Oct 16, 2017

Conversation

Projects
None yet
7 participants
@ohayon
Member

ohayon commented Oct 3, 2017

We need to reliably capture metrics in order to understand how fastlane is used. Our metrics gathering isn’t reliable and can be hard to understand. As such, we have an incomplete view of fastlane usage, so it's difficult to understand what features need more love, which ones could be made easier to use, and how we can make it more stable.

@googlebot googlebot added the cla: yes label Oct 3, 2017

@fastlane-bot-helper

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot-helper

fastlane-bot-helper Oct 3, 2017

Contributor
1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Contributor

fastlane-bot-helper commented Oct 3, 2017

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

ohayon added some commits Oct 3, 2017

@taquitos taquitos changed the title from [WIP] New metrics to [WIP] Refactoring metrics to be more understandable Oct 3, 2017

taquitos added some commits Oct 3, 2017

Implemented methods that build dictionaries representing:
action_launched
action_completed
events
Fixed "actor" entry in event
removed errant tab
def is_fastfile=(value)
if value
# If true, update all of the events to reflect

This comment has been minimized.

@taquitos

taquitos Oct 13, 2017

Member

you write the best comments. I can't wait to go back to make changes and understand why you built things the way you did. Old code is wise code, but clear comments detailing decisions are 💯

@taquitos

taquitos Oct 13, 2017

Member

you write the best comments. I can't wait to go back to make changes and understand why you built things the way you did. Old code is wise code, but clear comments detailing decisions are 💯

# Learn more at https://github.com/fastlane/fastlane#metrics
return if FastlaneCore::Env.truthy?("FASTLANE_OPT_OUT_USAGE")
client.post_events(@events)

This comment has been minimized.

@taquitos

taquitos Oct 13, 2017

Member

ONE PLACE TO POST EVENTS!!!! Yessssssss the best. So much easier to determine where we send stuff

@taquitos

taquitos Oct 13, 2017

Member

ONE PLACE TO POST EVENTS!!!! Yessssssss the best. So much easier to determine where we send stuff

# This method is only for debugging purposes
def write_json(body)
File.write("#{ENV['HOME']}/Desktop/mock_analytics-#{Time.now.to_i}.json", body)

This comment has been minimized.

@mpirri

mpirri Oct 13, 2017

Contributor

Okay, this one is pretty edge casey, I admit - Linux users don't have a Desktop directory. Maybe /tmp ? 🤷‍♂️

@mpirri

mpirri Oct 13, 2017

Contributor

Okay, this one is pretty edge casey, I admit - Linux users don't have a Desktop directory. Maybe /tmp ? 🤷‍♂️

end
end
# here are a bunch of tests we should also have

This comment has been minimized.

@mpirri

mpirri Oct 13, 2017

Contributor

What can we do to keep these from slipping through the cracks? 🤔

@mpirri

mpirri Oct 13, 2017

Contributor

What can we do to keep these from slipping through the cracks? 🤔

This comment has been minimized.

@ohayon

ohayon Oct 16, 2017

Member

made a trello card for this!

@ohayon

ohayon Oct 16, 2017

Member

made a trello card for this!

@@ -39,6 +39,8 @@ module SpecHelper
# This was a request that was added with Ruby 2.4.0
allow(Fastlane::FastlaneRequire).to receive(:install_gem_if_needed).and_return(nil)
ENV['FASTLANE_PLATFORM_NAME'] = nil

This comment has been minimized.

@mpirri

mpirri Oct 13, 2017

Contributor

What's this for?

@mpirri

mpirri Oct 13, 2017

Contributor

What's this for?

This comment has been minimized.

@ohayon

ohayon Oct 13, 2017

Member

some env var state that needed to be cleared out :(

@ohayon

ohayon Oct 13, 2017

Member

some env var state that needed to be cleared out :(

ohayon added some commits Oct 13, 2017

@ohayon ohayon changed the title from [WIP] Refactoring metrics to be more understandable to Refactoring metrics to be more understandable Oct 16, 2017

@mpirri

mpirri approved these changes Oct 16, 2017

AWESOME! 🥇

@ohayon ohayon merged commit 6b8718f into master Oct 16, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
dependency-ci Dependencies checked
Details

@ohayon ohayon deleted the metrics-reconsideration branch Oct 16, 2017

@mpirri mpirri referenced this pull request Oct 16, 2017

Merged

Version bump to 2.62.0 #10608

bramseynhaeve added a commit to bramseynhaeve/fastlane that referenced this pull request Oct 17, 2017

Merge branch 'master' into import_from_git_versioning
* master: (121 commits)
  Set a default p_hash for metrics (fastlane#10610)
  Refactoring metrics to be more understandable (fastlane#10488)
  Updating options for docs update fastlane/docs#432 (fastlane#10593)
  [docs] fix links (fastlane#10591)
  Find nested errors messages (fastlane#10586)
  [UpdateProjectTeam] default path value (fastlane#10583)
  Fix waiting during network activity for iPhone X (fastlane#10541)
  [hockey] clarify error message (fastlane#10568)
  Add swift_version option to pod_push action (fastlane#10570)
  Fix documentation URL in default Deliverfile (fastlane#10575)
  Add verbose output for upload_dsym (fastlane#10537)
  Gym: add option to skip profile detection (fastlane#10463)
  Make gym pass xcargs to xcbuild-safe.sh (fastlane#10571)
  [spaceship] Fixed and improved upload_trailer! method (fastlane#10546)
  Only query xcode version on macs when running itms (fastlane#10545)
  update `:update_docs` commit and Slack message (fastlane#10544)
  Version bump to 2.61.0 (fastlane#10527)
  Update image paths of docs (fastlane#10529)
  [backup_xcarchive] Add custom xcarchive zip filename option (fastlane#10540)
  Update code samples to pass docs tests (fastlane#10528)
  ...
@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Oct 17, 2017

Hey @ohayon 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

fastlane-bot commented Oct 17, 2017

Hey @ohayon 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Oct 18, 2017

Congratulations! 🎉 This was released as part of fastlane 2.62.0 🚀

fastlane-bot commented Oct 18, 2017

Congratulations! 🎉 This was released as part of fastlane 2.62.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Dec 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.