New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin details optional #10628

Merged
merged 3 commits into from Oct 18, 2017

Conversation

Projects
None yet
4 participants
@KrauseFx
Member

KrauseFx commented Oct 18, 2017

Most users won't know the details at this point yet, there is no good reason to ask them there I think

Make plugin details optional
Most users won't know the details at this point yet, there is no good reason to ask them there I think

@googlebot googlebot added the cla: yes label Oct 18, 2017

@taquitos

🤔

🎈🐐

KrauseFx added some commits Oct 18, 2017

@KrauseFx KrauseFx merged commit 1db316b into master Oct 18, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
dependency-ci Dependencies checked
Details

@KrauseFx KrauseFx deleted the make-details-options branch Oct 18, 2017

@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Oct 19, 2017

Hey @KrauseFx 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

fastlane-bot commented Oct 19, 2017

Hey @KrauseFx 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@ohayon ohayon referenced this pull request Oct 23, 2017

Merged

Version bump to 2.62.1 #10670

laullon added a commit to laullon/fastlane that referenced this pull request Oct 23, 2017

Merge branch 'master' into snapshot-record-video
* master: (96 commits)
  [snapshot] Fix unused result warning in helper (fastlane#10662)
  Typo Fix (fastlane#10661)
  Version bump to 2.62.1 (fastlane#10670)
  Support manual signingStyle (fastlane#10508)
  Dont count lane switches in metrics (fastlane#10659)
  Add missing html tag (fastlane#10657)
  Deprecates add_id_info_limits_tracking in favor of add_id_info_uses_idfa (fastlane#10653)
  [fastlane core] fix unit tests when Xcode 9.0 not installed (fastlane#10655)
  Add automatic commiting of mkdocs.yml for docs generation (fastlane#10578)
  [Client] Handle Faraday::ParsingError as part of Client#with_retry logic (fastlane#10646)
  Revert "[BuildWatcher] Handle parse error while waiting for build processing (fastlane#10621)" (fastlane#10647)
  [BuildWatcher] Handle parse error while waiting for build processing (fastlane#10621)
  Remove 'zip' example from update_info_plist (fastlane#10494)
  Make plugin details optional (fastlane#10628)
  fix leaking sw_vers (fastlane#10630)
  Update snapshot instructions (fastlane#10626)
  Update update instructions of snapshot (fastlane#10627)
  Don't add unneeded new-line when asking for user input (fastlane#10629)
  Forward match keychain password into cert (fastlane#10619)
  SW_VERS should be lowercase (fastlane#10625)
  ...

# Conflicts:
#	README.md
#	cert/README.md
#	snapshot/README.md
#	snapshot/lib/assets/SnapshotHelper.swift
@fastlane-bot

This comment has been minimized.

Show comment
Hide comment
@fastlane-bot

fastlane-bot Oct 24, 2017

Congratulations! 🎉 This was released as part of fastlane 2.62.1 🚀

fastlane-bot commented Oct 24, 2017

Congratulations! 🎉 This was released as part of fastlane 2.62.1 🚀

@fastlane fastlane locked and limited conversation to collaborators Dec 23, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.